all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 50431@debbugs.gnu.org
Subject: bug#50431: revert-buffer doesn't preserve read-onlyness
Date: Wed, 24 Aug 2022 20:12:50 +0300	[thread overview]
Message-ID: <86edx5o99p.fsf@mail.linkov.net> (raw)
In-Reply-To: <87h721oowl.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 24 Aug 2022 13:35:06 +0200")

>> I don't know at what moment this regression occurred,
>> but now M-x revert-buffer in a read-only file buffer
>> doesn't keep it read-only.
>
> I've now fixed this in Emacs 29 -- `C-x C-q' records what the user
> actually did, so we can restore that state.
>
> If the user hasn't used that command, then reverting works as before --
> it uses the permission bits on the file and updates the readedness
> state.
>
> I considered only heeding the user-set readedness state if it was
> different from the default one -- that is, if the user used the `C-x
> C-q' command twice, then readedness state would not be preserved by
> reverting, but I think that's too subtle.

I confirm that now the read-only status is restored,
but reverting loses view-mode:

  C-h C-t  -- note "View" on the mode-line;
  C-x x g  -- "View" is lost.





  reply	other threads:[~2022-08-24 17:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-06 15:03 bug#50431: revert-buffer doesn't preserve read-onlyness Juri Linkov
2021-09-06 16:38 ` Glenn Morris
2021-09-07 15:52   ` Lars Ingebrigtsen
2021-09-09  3:07     ` Richard Stallman
2021-09-09 13:16       ` Lars Ingebrigtsen
2021-09-09 17:27   ` Juri Linkov
2022-08-24 11:35 ` Lars Ingebrigtsen
2022-08-24 17:12   ` Juri Linkov [this message]
2022-08-25 14:03     ` Lars Ingebrigtsen
2022-08-25 18:02       ` Juri Linkov
2022-08-25 18:55         ` Eli Zaretskii
2022-08-25 19:35           ` Juri Linkov
2022-08-26  5:34             ` Eli Zaretskii
2022-08-26  7:17               ` Juri Linkov
2022-08-26 16:10               ` Drew Adams
2022-08-26 10:41           ` Lars Ingebrigtsen
2022-08-26 10:48             ` Eli Zaretskii
2022-08-26 16:24               ` Drew Adams
2022-08-27 13:15               ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86edx5o99p.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=50431@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.