From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#57400: 29.0.50; Support sending patches from VC directly Date: Sat, 08 Oct 2022 22:34:16 +0300 Organization: LINKOV.NET Message-ID: <86edvids93.fsf@mail.linkov.net> References: <84v8qgn1z9.fsf@iki.fi> <87h71zo3p8.fsf@posteo.net> <87sfljmgwz.fsf@posteo.net> <87y1twvima.fsf@posteo.net> <84sfk2p846.fsf@iki.fi> <87h70i9ntt.fsf@posteo.net> <87edvl6vbj.fsf@gmail.com> <8735c1nn3y.fsf@posteo.net> <877d1d6rcy.fsf@gmail.com> <867d1cjc8w.fsf@mail.linkov.net> <87o7unkggk.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26908"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Robert Pluim , 57400@debbugs.gnu.org, Antoine Kalmbach To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 08 21:44:31 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohFkN-0006nk-5X for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Oct 2022 21:44:31 +0200 Original-Received: from localhost ([::1]:45366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohFkL-0006xC-Ky for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Oct 2022 15:44:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34294) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohFjv-0006wt-O1 for bug-gnu-emacs@gnu.org; Sat, 08 Oct 2022 15:44:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42417) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohFjt-00044u-U8 for bug-gnu-emacs@gnu.org; Sat, 08 Oct 2022 15:44:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ohFjt-0000cu-Jr for bug-gnu-emacs@gnu.org; Sat, 08 Oct 2022 15:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Oct 2022 19:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57400 X-GNU-PR-Package: emacs Original-Received: via spool by 57400-submit@debbugs.gnu.org id=B57400.16652581842335 (code B ref 57400); Sat, 08 Oct 2022 19:44:01 +0000 Original-Received: (at 57400) by debbugs.gnu.org; 8 Oct 2022 19:43:04 +0000 Original-Received: from localhost ([127.0.0.1]:41495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohFiy-0000bZ-2c for submit@debbugs.gnu.org; Sat, 08 Oct 2022 15:43:04 -0400 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:57559) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohFiw-0000b3-2B for 57400@debbugs.gnu.org; Sat, 08 Oct 2022 15:43:02 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 76C4420002; Sat, 8 Oct 2022 19:42:50 +0000 (UTC) In-Reply-To: <87o7unkggk.fsf@posteo.net> (Philip Kaludercic's message of "Fri, 07 Oct 2022 11:42:35 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244934 Archived-At: >> We could base the name of the existing commands. There is the command >> 'submit-emacs-patch', so the corresponding VC command could be >> 'vc-submit-patch'. Also like the existing command 'git-send-email' >> the name could be 'vc-send-patch'. > > So should I rename the command? I'm not committed to any name. The current name is fine. >> Also please note that the most convenient way to select revisions >> to submit is to show the log buffer, and use 'm' to mark revisions >> (log-view-toggle-mark-entry). Then 'log-view-get-marked' returns >> all marked revisions. > > This is supported, Thanks. Since it's the most convenient UI, shouldn't this be documented in the Info? IOW, what about copying this from the docstring to the manual: When invoked interactively in a Log View buffer with marked revisions, these revisions will be used. Also the use of "," to separate revisions needs to be documented in the docstrings and the manual. Maybe also mention the separator in the prompt that reads multiple revisions. > but currently not in this order. Do you think an option should be > added that would use recursive editing to prompt the user? I see that currently the chronological order of revisions is used from the log. This looks like the right order. Prompting with the default value that is set to these revisions from the log would be also nice to do, so users will be able to change the order manually by moving revisions between ",". Additional question: shouldn't the behavior of vc-prepare-patches-separately=nil be equivalent to vc-prepare-patches-separately=t when only one revision is given? Both cases create just one mail. So when vc-prepare-patches-separately is nil, could it extract the subject from the single revision? Or maybe vc-prepare-patches-separately should support a new customization value for this?