From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.bugs Subject: bug#59149: [SPAM UNSURE] Re: bug#59149: Feature Request: Report progress of long requests in Eglot Date: Thu, 24 Nov 2022 03:06:01 -0800 Message-ID: <86edtsk3xi.fsf@stephe-leake.org> References: <87educqkar.fsf@dfreeman.email> <86cz9jmg9r.fsf@stephe-leake.org> <87k03qvmla.fsf@dfreeman.email> <86fseckwvb.fsf@stephe-leake.org> <87tu2pohub.fsf@dfreeman.email> <86ilj5k0sn.fsf@stephe-leake.org> <87wn7l316m.fsf@dfreeman.email> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17794"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 59149@debbugs.gnu.org, danny@dfreeman.email To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 24 12:07:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyA4W-0004NO-Nd for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Nov 2022 12:07:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyA4P-0008TM-4C; Thu, 24 Nov 2022 06:07:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyA4O-0008TB-0w for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 06:07:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyA4M-00072U-Vq for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 06:07:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oyA4M-0007M9-Q1 for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 06:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Leake Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Nov 2022 11:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59149 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: 59149@debbugs.gnu.org, bug-gnu-emacs@gnu.org, Danny Freeman Original-Received: via spool by 59149-submit@debbugs.gnu.org id=B59149.166928799528234 (code B ref 59149); Thu, 24 Nov 2022 11:07:02 +0000 Original-Received: (at 59149) by debbugs.gnu.org; 24 Nov 2022 11:06:35 +0000 Original-Received: from localhost ([127.0.0.1]:57499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyA3u-0007LJ-Oa for submit@debbugs.gnu.org; Thu, 24 Nov 2022 06:06:35 -0500 Original-Received: from gproxy5-pub.mail.unifiedlayer.com ([67.222.38.55]:57466 helo=progateway7-pub.mail.pro1.eigbox.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyA3m-0007Kn-F5 for 59149@debbugs.gnu.org; Thu, 24 Nov 2022 06:06:27 -0500 Original-Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 45BF510045C1D for <59149@debbugs.gnu.org>; Thu, 24 Nov 2022 11:06:05 +0000 (UTC) Original-Received: from host2007.hostmonster.com ([67.20.76.71]) by cmsmtp with ESMTP id yA3RoH4EshFiDyA3RoOhFo; Thu, 24 Nov 2022 11:06:05 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=D6qCltdj c=1 sm=1 tr=0 ts=637f501d a=dWLzHQi6WpdymmZIwiVdBw==:117 a=Fln8i1WyhtedwaIJAdHvmw==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10:nop_charset_1 a=9xFQ1JgjjksA:10:nop_rcvd_month_year a=vvvmwbhNdt4A:10:endurance_base64_authed_username_1 a=pGLkceISAAAA:8 a=9i_RQKNPAAAA:8 a=mDV3o1hIAAAA:8 a=-DT5V8tOZ-5R5dM_jc8A:9 a=QEXdDO2ut3YA:10:nop_charset_2 a=hqnlY9SSy_kA:10:uccc_2email_address a=rBogvggfiPsA:10:demote_hacked_domain_1 a=Ev4oQ7kfJBNsvnoXShoW:22 a=_FVE-zBwftR9WsbkzFJk:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stephe-leake.org; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=T/UAFkSw1Clo3RuySrGC8eRBYCE6B8wPWjkS68OT5DQ=; b=ioQSZQ8J762qcsduSNrQKqV1T9 73FdlNFTRCSVXWUtRgXNQvG4FLTJX9ahT02qFtqNN4kxStQIG5bJxqSONFB2QKCLTo/tuRv0khH8j znaDwhZMTi7wKDegKUbPy5kBUgwFyje+EYYEJixtKHzyZcsOKPRVaMaE+2764DbfZ9phnAmTVRikn CViJz7Tb9vNhAF1P8AM9ax2MsGxye8Z8HqpJ+u4/Xkn4K4z5l7pADFWbP3mf3zCUOsSi8LyJscPkj Aa9rxCJAlR23tQba7Jf0JX7COJpP69tNED9/jiX6ILCxMnmWMzRT32UoToeyTKy8y86DldT332HWh GPE9BfZQ==; Original-Received: from 135-180-197-170.fiber.dynamic.sonic.net ([135.180.197.170]:57788 helo=DESKTOP-G20DCG1) by host2007.hostmonster.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oyA3Q-004A6N-Kf; Thu, 24 Nov 2022 04:06:04 -0700 In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Wed, 23 Nov 2022 19:56:27 +0000") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host2007.hostmonster.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stephe-leake.org X-BWhitelist: no X-Source-IP: 135.180.197.170 X-Source-L: No X-Exim-ID: 1oyA3Q-004A6N-Kf X-Source-Sender: 135-180-197-170.fiber.dynamic.sonic.net (DESKTOP-G20DCG1) [135.180.197.170]:57788 X-Source-Auth: stephen_leake@stephe-leake.org X-Email-Count: 3 X-Source-Cap: c3RlcGhlbGU7c3RlcGhlbGU7aG9zdDIwMDcuaG9zdG1vbnN0ZXIuY29t X-Local-Domain: yes X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248854 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > On Wed, Nov 23, 2022 at 7:45 PM Danny Freeman wrot= e: >> >> >> Stephen Leake writes: >> >> I am copying him on this email, as I realize he wasn't on this branch of >> the email chain. Jo=C3=A3o, please see the previous emails in the thread= for >> more context! Here is a link for convenience: >> https://lists.gnu.org/archive/html/bug-gnu-emacs/2022-11/msg01619.html > > Yep this is all news to me, but no problem, I just read through the chain. > > If, like Stephen says, $progress is part of the base protocol, then there= 's > no capability associated indeed, but I think we should just make up one > like `:$progress`, and use change eglot--server-capable-p to be able > to respond unequivocally 't' to those special built in capabilities, but > only after checking if they're not in the eglot-ignored-server-capabiliti= es > list. One way to do that is to simply add (:$progresss t) in eglot--connect where eglot--capabilities is set. But apply-text-edits creates a progress reporter that is not driven by messages from the lsp server; it's just processing a local list of edits. And I would like to be able to turn that off, but keep (at least some of) the lsp progress messages. LSP capabilities handle this by adding items in categories, so we could add (:$progress (:apply-edit t)) to eglot--capabilities, and then I could add :apply-edit to eglot-ignored-server-capabilities. We'd have to do the same for any other progress message somebody wants to turn off. Except that would also turn off apply-edit itself, not just the progress messages for it; it seems we need to allow eglot-ignored-server-capabilities to contain (:$progress :apply-edit). Or use :apply-edit-progress instead. --=20 -- Stephe