From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: master 128ed5c9f17: Add one more mouse-set-point call to functions xref-find-*-at-mouse Date: Thu, 31 Aug 2023 09:37:12 +0300 Organization: LINKOV.NET Message-ID: <86edjj7m5j.fsf@mail.linkov.net> References: <169344150641.11482.13012085201452768898@vcs2.savannah.gnu.org> <20230831002506.C0C6DC038B5@vcs2.savannah.gnu.org> <87il8wt52f.fsf@yahoo.com> <583ae120-d016-e9e8-2783-db21c1e018b8@gutov.dev> <87edjkt3sn.fsf@yahoo.com> <6c5251b1-c289-07cf-587d-013c781e31f5@gutov.dev> <8734zzudo7.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6825"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Dmitry Gutov , emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 31 09:03:36 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbbiJ-0001cY-0K for ged-emacs-devel@m.gmane-mx.org; Thu, 31 Aug 2023 09:03:35 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbbht-0002j1-Tp; Thu, 31 Aug 2023 03:03:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbbhr-0002dC-L1 for emacs-devel@gnu.org; Thu, 31 Aug 2023 03:03:07 -0400 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbbho-0007ug-IP for emacs-devel@gnu.org; Thu, 31 Aug 2023 03:03:07 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id CBED81BF210; Thu, 31 Aug 2023 07:02:59 +0000 (UTC) In-Reply-To: <8734zzudo7.fsf@yahoo.com> (Po Lu's message of "Thu, 31 Aug 2023 10:51:52 +0800") X-GND-Sasl: juri@linkov.net Received-SPF: pass client-ip=217.70.183.201; envelope-from=juri@linkov.net; helo=relay8-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:309601 Archived-At: > My point is this: xref-find-definitions itself, not its callers, should > take EVENT, then call (goto-char (posn-point (event-start event))) > within. Alas, most of the commands don't support EVENT. It's a real problem for menu items at the bottom of the context menu where submenus are constructed from major/minor modes. For example, in emacs-lisp-mode clicking on "Emacs-Lisp -> Indent Line" operates on the line where point is located, not on the clicked line. And the rest of commands do the same. Maybe while constructing the context menu, some commands should be wrapped with a new function that will use '(save-excursion (mouse-set-point event))'. The problem is that this is necessary only for some of them, not all: only for the commands that rely on the position of the mouse click, not for the commands that operate on the whole buffer. For example, in emacs-lisp-mode only for the menu item "Evaluate Last S-expression", but not for "Evaluate Buffer".