all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Yuan Fu <casouri@gmail.com>
Cc: 68824@debbugs.gnu.org
Subject: bug#68824: treesitter support for outline-minor-mode
Date: Mon, 05 Feb 2024 09:22:08 +0200	[thread overview]
Message-ID: <86eddrl6jj.fsf@mail.linkov.net> (raw)
In-Reply-To: <D9051D6F-4653-49E9-A615-A70D025575FC@gmail.com> (Yuan Fu's message of "Sun, 4 Feb 2024 20:34:24 -0800")

>> Also a remaining question: why treesit-parent-until simply calls
>> ‘(funcall pred node)’ instead of supporting the standard format
>> that includes a regexp by using treesit-node-match-p?
>> 
>> This causes such an inconvenience that for treesit-outline-level
>> that uses treesit-parent-until there is a need to wrap a regexp
>> in a lambda such as for html-ts-mode below.
>
> Nothing other than my oversight :-)
> I pushed a change to master that fixes this.

Thanks.  It seems you forgot to replace 'funcall'
in 'treesit-parent-while' as well?  ;-)

> As for the patch, I think treesit-outline-predicate could be set to
> a named function rather than a lambda generated on the fly, but
> I don’t have strong opinions about it (and maybe you have some reason
> to use a lambda?) Otherwise LGTM.

I completely agree, so will move lambdas to the named functions.





  reply	other threads:[~2024-02-05  7:22 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-30 17:37 bug#68824: treesitter support for outline-minor-mode Juri Linkov
2024-01-30 18:46 ` john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-31  7:20   ` Juri Linkov
2024-01-30 19:21 ` Eli Zaretskii
2024-01-31  7:32   ` Juri Linkov
2024-02-01 17:12     ` Juri Linkov
2024-02-02  0:34       ` Yuan Fu
2024-02-02  7:05         ` Eli Zaretskii
2024-02-02  7:27           ` Yuan Fu
2024-02-02  7:34             ` Eli Zaretskii
2024-02-02  7:53         ` Juri Linkov
2024-02-04 17:15         ` Juri Linkov
2024-02-05  4:34           ` Yuan Fu
2024-02-05  7:22             ` Juri Linkov [this message]
2024-02-06  7:21               ` Yuan Fu
2024-02-08  7:40     ` Juri Linkov
2024-02-08  8:30       ` Eli Zaretskii
2024-02-08 17:20         ` Juri Linkov
2024-02-08 18:56           ` Eli Zaretskii
2024-02-09  7:07             ` Juri Linkov
2024-02-09 19:25               ` Eli Zaretskii
2024-02-10 17:29                 ` Juri Linkov
2024-02-10 17:57                   ` Eli Zaretskii
2024-02-11 17:34                     ` Juri Linkov
2024-02-11 19:22                       ` Eli Zaretskii
2024-02-12  1:07                         ` Yuan Fu
2024-02-12 12:59                           ` Eli Zaretskii
2024-02-12 18:16                             ` Juri Linkov
2024-02-13 17:02                               ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86eddrl6jj.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=68824@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.