From: Eli Zaretskii <eliz@gnu.org>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: emacs-devel@gnu.org
Subject: Re: emacs-29 4c6653f23ae: ; * lisp/emacs-lisp/pcase.el (pcase-let*, pcase-let): Doc fix.
Date: Tue, 20 Feb 2024 19:16:24 +0200 [thread overview]
Message-ID: <86edd7njiv.fsf@gnu.org> (raw)
In-Reply-To: <87edd79jc2.fsf@gmx.net> (message from Stephen Berman on Tue, 20 Feb 2024 17:44:13 +0100)
> From: Stephen Berman <stephen.berman@gmx.net>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Tue, 20 Feb 2024 17:44:13 +0100
>
> On Tue, 20 Feb 2024 08:44:36 -0500 (EST) Eli Zaretskii <eliz@gnu.org> wrote:
>
> > branch: emacs-29
> > commit 4c6653f23aef097e3a6ed687e21decea6c790b5e
> > Author: Eli Zaretskii <eliz@gnu.org>
> > Commit: Eli Zaretskii <eliz@gnu.org>
> >
> > ; * lisp/emacs-lisp/pcase.el (pcase-let*, pcase-let): Doc fix.
> > ---
> > lisp/emacs-lisp/pcase.el | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/lisp/emacs-lisp/pcase.el b/lisp/emacs-lisp/pcase.el
> > index 47db2b89b9e..692c8f9b3fe 100644
> > --- a/lisp/emacs-lisp/pcase.el
> > +++ b/lisp/emacs-lisp/pcase.el
> > @@ -261,7 +261,7 @@ As with `pcase-let', BINDINGS are of the form (PATTERN EXP), but the
> > EXP in each binding in BINDINGS can use the results of the destructuring
> > bindings that precede it in BINDINGS' order.
> >
> > -Each EXP should match (i.e. be of compatible structure) to its
> > +Each EXP should match (i.e. be of compatible structure) its
> > respective PATTERN; a mismatch may signal an error or may go
> > undetected, binding variables to arbitrary values, such as nil."
> > (declare (indent 1)
> > @@ -283,7 +283,7 @@ All EXPs are evaluated first, and then used to perform destructuring
> > bindings by matching each EXP against its respective PATTERN. Then
> > BODY is evaluated with those bindings in effect.
> >
> > -Each EXP should match (i.e. be of compatible structure) to its
> > +Each EXP should match (i.e. be of compatible structure) its
> > respective PATTERN; a mismatch may signal an error or may go
> > undetected, binding variables to arbitrary values, such as nil."
> > (declare (indent 1) (debug pcase-let*))
>
> "Each EXP should match (i.e. be of compatible structure) its respective
> PATTERN" is still a solecism;
You are welcome.
> correct English would be "Each EXP should
> match (i.e., be of compatible structure to) its respective PATTERN". An
> alternative, and perhaps more fluid, formulation is "Each EXP should
> match its respective PATTERN (i.e., be of compatible structure to it)".
Thanks, fixed.
prev parent reply other threads:[~2024-02-20 17:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <170843667620.14405.8788254349626937984@vcs2.savannah.gnu.org>
[not found] ` <20240220134436.8A18FC00227@vcs2.savannah.gnu.org>
2024-02-20 16:44 ` emacs-29 4c6653f23ae: ; * lisp/emacs-lisp/pcase.el (pcase-let*, pcase-let): Doc fix Stephen Berman
2024-02-20 17:16 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86edd7njiv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.