From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 5a125fb5a97 1/2: Update to Org 9.7.3 Date: Thu, 13 Jun 2024 16:43:14 +0300 Message-ID: <86ed91yn4d.fsf@gnu.org> References: <171796793548.23337.12512115872160390161@vcs2.savannah.gnu.org> <20240609211858.A2C31C1F9FB@vcs2.savannah.gnu.org> <87a5jtd403.fsf@yahoo.com> <87h6e1lhtd.fsf@kyleam.com> <868qzd9hjg.fsf@gnu.org> <871q53u75e.fsf@localhost> <8634pj7jni.fsf@gnu.org> <878qz9gfp1.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26588"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, kyle@kyleam.com, emacs-devel@gnu.org To: Ihor Radchenko Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 13 15:44:20 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sHkkT-0006fw-9t for ged-emacs-devel@m.gmane-mx.org; Thu, 13 Jun 2024 15:44:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sHkjk-0007M9-Br; Thu, 13 Jun 2024 09:43:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHkja-0007Ht-3p for emacs-devel@gnu.org; Thu, 13 Jun 2024 09:43:22 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHkjX-0004p2-Ll; Thu, 13 Jun 2024 09:43:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=1nDgCIBmyD+GIBFpKGMdY9D9XMDYmhsImd9dOGtIEQs=; b=BYV/ma+wPeLl wApGnIPHSA4Sswer67Bo1/pMYMo0j4s6ogb6MoXw5kqSejABBUdEdtOzGX96AZuhPB9P8kUa9zdO8 onvOXbDo5lbZftK2q11lkiSpAe6Yjk6LiYJe8CDUhaEZuPhtgNHgO+rmzvoUffgE2ShTkazBBWGBh KJhVg3XlCQy8KlTZahXEPs3nj6IixrwsUDRK4ZIOwSRML3VQTzaH9zNo2XZX1NTSQWKi5fJy99oTN cCMYtZitIM9YDIgCCt0WsKVMa66f4rJayAHvvPnEFAFcZ+XjAniT+k015mgBDpqFefGaeT3cBiO14 GMYjLESYdEYPiDqPXIEF6g==; In-Reply-To: <878qz9gfp1.fsf@localhost> (message from Ihor Radchenko on Thu, 13 Jun 2024 13:00:58 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320021 Archived-At: > From: Ihor Radchenko > Cc: Stefan Monnier , kyle@kyleam.com, > emacs-devel@gnu.org > Date: Thu, 13 Jun 2024 13:00:58 +0000 > > >> Of course, we can always convert that lambda into a proper function, > >> which will likely get rid of the warning. > > > > Yes, please. Emacs 28 and later has list-of-strings-p, but if you > > want to support older versions of Emacs, perhaps that's not usable. > > Or maybe we could add that to compat.el. > > Org cannot directly use compat.el for now. > I am attaching tentative patch that defines a compatibility alias and > autoloads it. > Is this approach good enough? Assuming you tested it and the warning is gone, including when visiting a file with that variable in file-locals section, then yes, this is good enough. But please also wait for Stefan's opinion.