From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Shell quoting in Eshell (was: eshell-batch-file) Date: Sat, 15 Jun 2024 12:38:02 +0300 Message-ID: <86ed8yv951.fsf@gnu.org> References: <86cyoqbq7m.fsf@gnu.org> <6a0e51ee-f4a2-c668-fcc7-eb83954539d5@gmail.com> <86bk4a9bcs.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21823"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Jim Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 15 11:38:35 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sIPrm-0005TN-PV for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Jun 2024 11:38:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sIPrM-0002X0-0d; Sat, 15 Jun 2024 05:38:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIPrK-0002UT-0T for emacs-devel@gnu.org; Sat, 15 Jun 2024 05:38:06 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIPrJ-00022n-OM; Sat, 15 Jun 2024 05:38:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VE3aE1wvhSrrJEbGbXeevH3hDBJALTpgEZr+1K+co7w=; b=WR3dsS03AXHs APlRUXX1Mbk62Wk3g34OAtl02vUUOaD6ACpFaTX5HjTNzwpFCWuCOB7k5NvGsgXPFmOuv3TBilXP+ v0qw5elJRFP0sjxIAHIZHeerZgu3s46NJSfcyCQMqEQWeb00+ojA+2gbtgLDwMdiB5VDhkYZwNqGA qxWJSwEzjEyjECwjOS77kMA21b+G3NJLw0Z6oL0kgSBqPpBTrTn1UiaiNPBTr3MjAzg1x4RGKGZ6S UcWFKz4/Gfz1PYGFEEo5J1NYCkIRr/3bKF/M/1vEqUywtje2d+fzQECikjYFEpasSWnzB1dLbPTiP PHlKTD9pJaLpp63zOsTMow==; In-Reply-To: (message from Jim Porter on Sun, 9 Jun 2024 15:37:05 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320125 Archived-At: > Date: Sun, 9 Jun 2024 15:37:05 -0700 > From: Jim Porter > Cc: emacs-devel@gnu.org > > There are just two changes you made that I'm not quite sure what to do > about. When you get the chance, could you apply the following patch and > report back the test failures you get? I get this failure: Test esh-proc-test/kill-pipeline backtrace: signal(ert-test-failed (((should (string-match-p (rx (or "interrupt\ ert-fail(((should (string-match-p (rx (or "interrupt\n" "killed\n" " (if (unwind-protect (setq value-164 (apply fn-162 args-163)) (setq f (let (form-description-166) (if (unwind-protect (setq value-164 (app (let ((value-164 'ert-form-evaluation-aborted-165)) (let (form-descr (let* ((fn-162 #'string-match-p) (args-163 (condition-case err (list (let ((output-start (eshell-beginning-of-output))) (eshell-kill-proc (save-current-buffer (set-buffer eshell-buffer) (eshell-insert-comma (unwind-protect (save-current-buffer (set-buffer eshell-buffer) (esh (let ((eshell-buffer (eshell t))) (unwind-protect (save-current-buff (let ((process-environment (cons "HISTFILE" process-environment)) (e (progn (let ((process-environment (cons "HISTFILE" process-environme (unwind-protect (progn (let ((process-environment (cons "HISTFILE" p (let* ((coding-system-for-write nil) (temp-file (file-name-as-direct (save-current-buffer (let* ((coding-system-for-write nil) (temp-file #f(lambda () [t] (let ((value-155 (gensym "ert-form-evaluation-abort #f(compiled-function () #)() handler-bind-1(#f(compiled-function () #