From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii <eliz@gnu.org> Newsgroups: gmane.emacs.bugs Subject: bug#74642: 31.0.50; [Patch] Turn off current source line indicator when gdb buffer is killed Date: Sat, 07 Dec 2024 15:25:20 +0200 Message-ID: <86ed2jiq0v.fsf@gnu.org> References: <87wmgiy38x.fsf@163.com> <868qsy442u.fsf@gnu.org> <87ldwxy11t.fsf@163.com> <86ed2p2bgm.fsf@gnu.org> <87frn3yi04.fsf@163.com> <8634j31s75.fsf@gnu.org> <86ed2nz2jc.fsf@gnu.org> <878qsuy44r.fsf@163.com> <86ikryy35q.fsf@gnu.org> <874j3iy182.fsf@163.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37866"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74642@debbugs.gnu.org To: Diancheng Wang <diancheng_wang@163.com> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 07 14:26:16 2024 Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org> Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>) id 1tJup6-0009iK-6a for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Dec 2024 14:26:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <bug-gnu-emacs-bounces@gnu.org>) id 1tJuoy-0008CX-HE; Sat, 07 Dec 2024 08:26:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1tJuos-0008BY-C2 for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 08:26:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1tJuor-0002SV-Ub for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 08:26:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=RkkCqKq9X3onairi+Ij8ryXlnV7TUBJNx/L/edrMnU0=; b=S30YU05YRJDn1bpSck8tqRWB9kv6FWAVaaTfKL7GLU6zJ/ppDjLq2wf2T8WKgIkJqkyxBZwczGtqu2W+d9EhSF9iRHfhEsvRe9lMmxaoa1UbV8RrRzsTZmRRX9OaCJoSE5lK5rpi8GQolvYmUcHsO6kTmbCC8gjlV6qupkMOG4hetPjTobNNpCDXIYQu4tqfAGqbDTKP7wNB2sqZDkK3UTB7ZEmXKxqkY/BLzdKiDMg7/Tp6/26NA+0359Cb1vPCnwjUViDHiqsvKyIbL5uICl6YFnr3lyR9N/tt0l4ngoVUiOhTEuJdLyYXRVwkMQB3H+d495dwGWD9loWty7rCLg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1tJuor-00058C-O4 for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2024 08:26:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii <eliz@gnu.org> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Dec 2024 13:26:01 +0000 Resent-Message-ID: <handler.74642.B74642.173357794919696@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74642 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74642-submit@debbugs.gnu.org id=B74642.173357794919696 (code B ref 74642); Sat, 07 Dec 2024 13:26:01 +0000 Original-Received: (at 74642) by debbugs.gnu.org; 7 Dec 2024 13:25:49 +0000 Original-Received: from localhost ([127.0.0.1]:45960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1tJuoe-00057b-PG for submit@debbugs.gnu.org; Sat, 07 Dec 2024 08:25:49 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@gnu.org>) id 1tJuoc-00057M-K0 for 74642@debbugs.gnu.org; Sat, 07 Dec 2024 08:25:47 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1tJuoQ-0002Fo-8Y; Sat, 07 Dec 2024 08:25:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=RkkCqKq9X3onairi+Ij8ryXlnV7TUBJNx/L/edrMnU0=; b=oSJEEtunvf45 3a4bCvBjFL9wMwt+ApVzP1gvl8X3jfrrxIgrteeW7EGb6L7+eUagjrBet6ifrr9KBrTZahLOoabIC T3HRqRD98+aISsJHOVZo2GI/KtqT85u1SA5tXu+d8h99hFdfm68Myi7DeELPUhcrWdIpFw3k/wUVS 36MXKKwqB50rQ0r6ZZ4cN1zLEOi75gwaBO2T/iJTT4kG46/DIh2auc7cMDCOsBfVoXjyO6K6Lc0Uq 6zaivF/LkYgcppWpxQ8EF+K9msXonj+9mdg5HqCjnGRshsJdJm1HPeeIV4qP2EU6lzjj6i1qWLkZN WeDfut8KLYvOtJPI26jLxQ==; In-Reply-To: <874j3iy182.fsf@163.com> (message from Diancheng Wang on Thu, 05 Dec 2024 16:37:33 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>, <mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/bug-gnu-emacs> List-Post: <mailto:bug-gnu-emacs@gnu.org> List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>, <mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe> Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296565 Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/296565> > From: Diancheng Wang <diancheng_wang@163.com> > Cc: 74642@debbugs.gnu.org > Date: Thu, 05 Dec 2024 16:37:33 +0800 > > Eli Zaretskii <eliz@gnu.org> writes: > > >> From: Diancheng Wang <diancheng_wang@163.com> > >> Cc: 74642@debbugs.gnu.org > >> Date: Thu, 05 Dec 2024 15:34:44 +0800 > >> > >> > Crystal ball says that the regression was caused by the change you > >> > submitted (and I installed) in bug#73687. It added a call to > >> > gud-hide-current-line-indicator to gdb-starting and to gud-sentinel. > >> > Could you try reverting those changes and see if that solves the > >> > problem in Emacs 31? > >> > >> Yes, There is a regression in my patch: the arrow on the source line is > >> not stopped displaying when "*gud-myprogram" got killed. But Emacs 30 > >> and Emacs 31 still have another issue: > >> gud-highlight-current-line-overlay is not destroyed when > >> "*gud-myprogram*" got killed. > > > > As I already wrote, I don't see the problem in Emacs 30: when I kill > > the *gud-myprogram* buffer, the arrow disappears. > > > >> To reproduce it, you need to evaluate (setq > >> gud-highlight-current-line t). > > > > So in Emacs 30 this only happens when gud-highlight-current-line is > > non-nil? > > Yes, the highlighted current source line in source file is not > un-highlighted when gud-highlight-current-line is non-nil. > > > > >> I updated my patch to fix this 2 issues, see attachment. > > > > Does this fix the problem with the current-line indicator (either on > > the fringe or as overlay-arrow) in both Emacs 30 and Emacs 31? > > > > Thanks. > > This patch depends on my previous patch, which is commit in master branch: > > --8<---------------cut here---------------start------------->8--- > > commit bd5d84e5d3311e7ab4a7d0091d6c98365927d17a > Author: Diancheng Wang <diancheng_wang@163.com> > Date: Tue Oct 8 11:11:24 2024 +0800 > > Stop highlighting current line when debuggee is running > > --8<---------------cut here---------------end--------------->8--- > > To apply this fix, Emacs 30 needs this commit. OK. But the master branch needs only your last patch, and does not need the original patch you posted in this bug report, is that right?