From: Ivan Kanis <expire-by-2009-09-28@kanis.fr>
To: dann@ics.uci.edu
Cc: emacs-devel@gnu.org
Subject: [PATCH] trivial patch, jumping cursor in term
Date: Wed, 23 Sep 2009 16:01:23 +0200 [thread overview]
Message-ID: <86d45hhia4.fsf@kanis.fr> (raw)
[-- Attachment #1: Type: text/plain, Size: 592 bytes --]
Hello Dan,
Here are the steps to reproduce the bug:
M-x term
C-x 2
Input a character
You'll see the cursor move to the top left when it shouldn't. I have
tracked the problem to the following call stack.
term-emulate-terminal
term-check-size
term-set-scroll-region
term-set-scroll-region
The cursor should move when receiving ESC [ R, so I've added a parameter
to term-set-scroll-region which will move the cursor if set to t.
Could you, please, apply the patch?
Kind regards,
--
Ivan
Kanis http://kanis.fr
Think like a man of action, act like a man of thought.
-- Henry Bergson
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: term-cursor.patch --]
[-- Type: text/x-diff, Size: 1001 bytes --]
diff -r b9b27a5565ff lisp/misc/term.el
--- a/lisp/misc/term.el Wed Sep 23 15:50:43 2009 +0200
+++ b/lisp/misc/term.el Wed Sep 23 15:52:10 2009 +0200
@@ -3377,10 +3377,11 @@
((eq char ?r)
(term-set-scroll-region
(1- term-terminal-previous-parameter)
- (1- term-terminal-parameter)))
+ (1- term-terminal-parameter)
+ t))
(t)))
-(defun term-set-scroll-region (top bottom)
+(defun term-set-scroll-region (top bottom &optional esc-bracket-r)
"Set scrolling region.
TOP is the top-most line (inclusive) of the new scrolling region,
while BOTTOM is the line following the new scrolling region (e.g. exclusive).
@@ -3398,7 +3399,8 @@
(not (and (= term-scroll-start 0)
(= term-scroll-end term-height)))))
(term-move-columns (- (term-current-column)))
- (term-goto 0 0))
+ (if esc-bracket-r
+ (term-goto 0 0)))
;; (defun term-switch-to-alternate-sub-buffer (set)
;; ;; If asked to switch to (from) the alternate sub-buffer, and already (not)
next reply other threads:[~2009-09-23 14:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-23 14:01 Ivan Kanis [this message]
2009-09-24 1:41 ` [PATCH] trivial patch, jumping cursor in term Dan Nicolaescu
2009-09-24 2:15 ` Stefan Monnier
2009-09-24 6:46 ` Ivan Kanis
2009-09-24 15:02 ` Stefan Monnier
2009-09-24 17:11 ` Dan Nicolaescu
2009-09-25 8:56 ` Ivan Kanis
2009-09-25 14:29 ` Stefan Monnier
2009-09-28 6:30 ` Ivan Kanis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86d45hhia4.fsf@kanis.fr \
--to=expire-by-2009-09-28@kanis.fr \
--cc=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.