From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sebastien Vauban <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
Subject: Re: [PATCH] Make the point visible when jumping to the mark
Date: Thu, 22 May 2014 10:56:30 +0200
Message-ID: <86d2f6gpj5.fsf@somewhere.org>
References: <874n1aq9y5.fsf@treetowl.lan> <87lhtvwakr.fsf@bzg.ath.cx>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org-mXXj517/zsQ@public.gmane.org>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request-mXXj517/zsQ@public.gmane.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode-mXXj517/zsQ@public.gmane.org>
List-Help: <mailto:emacs-orgmode-request-mXXj517/zsQ@public.gmane.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request-mXXj517/zsQ@public.gmane.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org-mXXj517/zsQ@public.gmane.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org-mXXj517/zsQ@public.gmane.org
To: emacs-orgmode-mXXj517/zsQ@public.gmane.org

Bastien wrote:
> Hi Ian,
>
> Please send me your public key so that I can give you access to the
> org-mode and worg repositories.
>
> Ian Kelling <ian-CsVmbpwo38eXwddmVfQv5g@public.gmane.org> writes:
>
>> From 9191e4a364e251119cf8b7c72e41f6c0d09583f2 Mon Sep 17 00:00:00 2001
>> Message-ID: <87ha5aqa93.fsf-OUiqzQ9FT5r+AlalS6MPSg@public.gmane.org>
>> MIME-Version: 1.0
>> Content-Type: text/plain
>>
>> *lisp/org.el: Advise commands which jump to the mark
>
> The formatting of the Changelog message not good.
>
> It should be
>
> * org.el: Advise commands which jump to the mark.
>
> See http://orgmode.org/worg/org-contribute.html and example in
> the git logs.
>
>> +(eval-after-load "simple"
>> +  '(defadvice set-mark-command (after org-make-visible activate)
>> +     "Make the point visible with `org-show-context'."
>> +     (org-mark-jump-unhide)))
>>
>> +(eval-after-load "simple"
>> +  '(defadvice exchange-point-and-mark (after org-make-visible activate)
>> +     "Make the point visible with `org-show-context'."
>> +     (org-mark-jump-unhide)))
>
>> +(eval-after-load "simple"
>> +  '(defadvice pop-global-mark (after org-make-visible activate)
>> +     "Make the point visible with `org-show-context'."
>> +     (org-mark-jump-unhide)))
>
> This two ones are good, yes.

Even if the goal is desirable, I thought that we may not add defadvice
in Emacs sources.

(... a couple of minutes later ...)

Well, Googling returns this :

  =E2=95=AD=E2=94=80=E2=94=80=E2=94=80=E2=94=80 http://www.gnu.org/software=
/emacs/manual/html_node/elisp/Advising-Functions.html
  =E2=94=82
  =E2=94=82 Emacs's own source files should not put advice on functions in
  =E2=94=82 Emacs. There are currently a few exceptions to this convention,=
 but we
  =E2=94=82 aim to correct them.
  =E2=95=B0=E2=94=80=E2=94=80=E2=94=80=E2=94=80

So, it seems this should be avoided as long as Org does go into Emacs.

Best regards,
  Seb

--=20
Sebastien Vauban