From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.bugs Subject: bug#33618: better fix Date: Sat, 20 Apr 2019 08:47:47 -0800 Message-ID: <86d0lg8vyk.fsf@stephe-leake.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="111222"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (windows-nt) To: 33618@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 20 19:12:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hHtXD-000Sl0-NU for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Apr 2019 19:12:15 +0200 Original-Received: from localhost ([127.0.0.1]:43544 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHtXC-0007UI-Nn for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Apr 2019 13:12:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39742) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHtX3-0007Tz-ES for bug-gnu-emacs@gnu.org; Sat, 20 Apr 2019 13:12:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hHtX2-0004Aw-If for bug-gnu-emacs@gnu.org; Sat, 20 Apr 2019 13:12:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33148) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hHtX1-00049p-FY for bug-gnu-emacs@gnu.org; Sat, 20 Apr 2019 13:12:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hHtX0-0001AE-Nh for bug-gnu-emacs@gnu.org; Sat, 20 Apr 2019 13:12:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Stephen Leake Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 Apr 2019 17:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33618 X-GNU-PR-Package: emacs Original-Received: via spool by 33618-submit@debbugs.gnu.org id=B33618.15557802784411 (code B ref 33618); Sat, 20 Apr 2019 17:12:02 +0000 Original-Received: (at 33618) by debbugs.gnu.org; 20 Apr 2019 17:11:18 +0000 Original-Received: from localhost ([127.0.0.1]:46692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHtWI-000195-Jv for submit@debbugs.gnu.org; Sat, 20 Apr 2019 13:11:18 -0400 Original-Received: from gproxy10-pub.mail.unifiedlayer.com ([69.89.20.226]:51500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHtWF-00018q-Th for 33618@debbugs.gnu.org; Sat, 20 Apr 2019 13:11:17 -0400 Original-Received: from cmgw11.unifiedlayer.com (unknown [10.9.0.11]) by gproxy10.mail.unifiedlayer.com (Postfix) with ESMTP id 36412140B3E for <33618@debbugs.gnu.org>; Sat, 20 Apr 2019 10:47:50 -0600 (MDT) Original-Received: from host114.hostmonster.com ([74.220.207.114]) by cmsmtp with ESMTP id Ht9ahjO1JVLCbHt9ahBDVt; Sat, 20 Apr 2019 10:47:50 -0600 X-Authority-Reason: nr=8 X-Authority-Analysis: $(_cmae_reason Original-Received: from [76.77.182.20] (port=52872 helo=Takver4) by host114.hostmonster.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hHt9Z-0029OZ-VS for 33618@debbugs.gnu.org; Sat, 20 Apr 2019 10:47:50 -0600 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host114.hostmonster.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stephe-leake.org X-BWhitelist: no X-Source-IP: 76.77.182.20 X-Source-L: No X-Exim-ID: 1hHt9Z-0029OZ-VS X-Source-Sender: (Takver4) [76.77.182.20]:52872 X-Source-Auth: stephen_leake@stephe-leake.org X-Email-Count: 1 X-Source-Cap: c3RlcGhlbGU7c3RlcGhlbGU7aG9zdDExNC5ob3N0bW9uc3Rlci5jb20= X-Local-Domain: yes X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157907 Archived-At: `grep-mode' is defined by `define-compilation-mode', which sets `compilation-search-path' to a buffer-local copy of `grep-search-path', if the latter is defined. So there is precedent for making custom vars buffer-local, and it seems the proper fix for this bug is to define `grep-search-path': --- a/lisp/progmodes/grep.el +++ b/lisp/progmodes/grep.el @@ -441,6 +441,14 @@ grep-find-abbreviate :version "27.1" :group 'grep) =20 +(defcustom grep-search-path '(nil) + "Search path for grep results. +Elements should be directory names, not file names of directories. +The value nil as an element means to try the default directory." + :group 'grep + :type '(repeat (choice (const :tag "Default" nil) + (string :tag "Directory")))) + (defvar grep-find-abbreviate-properties (let ((ellipsis (if (char-displayable-p ?=E2=80=A6) "[=E2=80=A6]" "[...]= ")) (map (make-sparse-keymap))) `emacs-lisp-compilation-mode' needs a similar fix: --- a/lisp/emacs-lisp/bytecomp.el +++ b/lisp/emacs-lisp/bytecomp.el @@ -1022,6 +1022,14 @@ emacs-lisp-compilation-parse-errors-filename-function "The value for `compilation-parse-errors-filename-function' for when we go into emacs-lisp-compilation-mode.") =20 +(defcustom emacs-lisp-compilation-search-path '(nil) + "Search path for byte-compile error messages. +Elements should be directory names, not file names of directories. +The value nil as an element means to try the default directory." + :group 'bytecomp + :type '(repeat (choice (const :tag "Default" nil) + (string :tag "Directory")))) + (define-compilation-mode emacs-lisp-compilation-mode "elisp-compile" "The variant of `compilation-mode' used for emacs-lisp error buffers") --=20 -- Stephe