From: Juri Linkov <juri@linkov.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Augusto Stoffel <arstoffel@gmail.com>, emacs-devel@gnu.org
Subject: Re: master 2b3f3d421a: Make minibuffer lazy highlight setup buffer-local where appropriate
Date: Thu, 19 May 2022 19:20:46 +0300 [thread overview]
Message-ID: <86czg9trgp.fsf@mail.linkov.net> (raw)
In-Reply-To: <jwva6beh8rs.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 18 May 2022 16:51:40 -0400")
>>> 1. With an active region, call C-M-%
>>> 2. Switch from the minibuffer back to the original buffer
>>> 3. Call keyboard-escape-quit (maybe twice) to quit the minibuffer
>>> prompt.
>>>
>>> Then the buffer-local value of `isearch-filter-predicate' is not cleaned
>>> up. Is it by any chance intentional that minibuffer-exit-hook doesn't
>>> run in this case?
>>
>> Indeed, a buffer-local minibuffer-exit-hook is not called
>> when the minibuffer is exited outside of the minibuffer.
>
> Looks like a bug.
> How 'bout the patch below?
Alas, it even breaks exiting the minibuffer directly from the minibuffer.
> - record_unwind_protect_void (run_exit_minibuf_hook);
> + record_unwind_protect (run_exit_minibuf_hook, Fcurrent_buffer ());
After a little debugging I see that everything is fixed after replacing
'Fcurrent_buffer ()' with 'minibuffer':
record_unwind_protect (run_exit_minibuf_hook, minibuffer);
next prev parent reply other threads:[~2022-05-19 16:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165264034407.21518.7194358780844409479@vcs2.savannah.gnu.org>
[not found] ` <20220515184546.6304CC01683@vcs2.savannah.gnu.org>
2022-05-15 20:16 ` master 2b3f3d421a: Make minibuffer lazy highlight setup buffer-local where appropriate Stefan Monnier
2022-05-15 21:10 ` Augusto Stoffel
2022-05-18 18:59 ` Juri Linkov
2022-05-18 20:51 ` Stefan Monnier
2022-05-19 16:20 ` Juri Linkov [this message]
2022-05-22 14:40 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86czg9trgp.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=arstoffel@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.