all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 45029@debbugs.gnu.org
Subject: bug#45029: 27.1.50; Regression: Yanking into externally modified file with delete-selection-mode
Date: Fri, 15 Sep 2023 19:06:20 +0300	[thread overview]
Message-ID: <86cyyjqwek.fsf@mail.linkov.net> (raw)
In-Reply-To: <jwvbke3y4ko.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 15 Sep 2023 09:17:14 -0400")

>>> The let-binding of `this-command` fixes the problem, doesn't it?
>> But might other uses of a recursive edit break it again?
>
> What do you mean by `it`?

Thanks for explanations.  I thought it is specific to
`delete-selection-mode` and `read-char-from-minibuffer`.
But since a combination of `pre-command-hook` and a recursive command
is a general problem, and OTOH `read-char-from-minibuffer` is already
safeguarded by the let-binding of `this-command`, so probably
`when (minibufferp)` could be removed from
`read-char-from-minibuffer-insert-other`.

> OTOH, the let-binding of `this-command` should fix the problem once and
> for all uses of recursive edit *if* it's placed deep enough that it
> affects all recursive edits.

Frankly speaking, I'm afraid of making such change at great depths ;-)





      reply	other threads:[~2023-09-15 16:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-03 20:10 bug#45029: 27.1.50; Regression: Yanking into externally modified file with delete-selection-mode Lars Ljung
2020-12-04 10:18 ` Lars Ingebrigtsen
2020-12-05 11:31   ` Eli Zaretskii
2020-12-05 19:42     ` Juri Linkov
2020-12-05 20:04       ` Eli Zaretskii
2020-12-06 21:12       ` Juri Linkov
2020-12-07  3:27         ` Eli Zaretskii
     [not found]       ` <jwv8r9aj7u3.fsf-monnier+emacs@gnu.org>
2023-09-13 17:59         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-14  6:39           ` Juri Linkov
2023-09-14 13:44             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-15  6:36               ` Juri Linkov
2023-09-15 13:17                 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-15 16:06                   ` Juri Linkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86cyyjqwek.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=45029@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.