From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Navigating completions from minibuffer Date: Sun, 19 Nov 2023 20:01:39 +0200 Organization: LINKOV.NET Message-ID: <86cyw5sjuk.fsf@mail.linkov.net> References: <25929.50004.710119.599023@google.com> <868r7af3v6.fsf@mail.linkov.net> <25930.31126.454503.607723@google.com> <868r78bsnx.fsf@mail.linkov.net> <87y1f569c0.fsf@catern.com> <86fs1c3yml.fsf@mail.linkov.net> <864jhokelp.fsf@mail.linkov.net> <86il62tbfa.fsf@mail.linkov.net> <861qcpu0ft.fsf@mail.linkov.net> <861qcorh4c.fsf@mail.linkov.net> <87jzqen5h0.fsf@catern.com> <86sf52tf0b.fsf@mail.linkov.net> <878r6tn6uf.fsf@catern.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4395"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Spencer Baugh Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 19 19:08:08 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r4mDH-00011g-Mo for ged-emacs-devel@m.gmane-mx.org; Sun, 19 Nov 2023 19:08:07 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r4mCy-0002fI-HK; Sun, 19 Nov 2023 13:07:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4mCw-0002fA-N5 for emacs-devel@gnu.org; Sun, 19 Nov 2023 13:07:46 -0500 Original-Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4mCu-0002Bw-Qj for emacs-devel@gnu.org; Sun, 19 Nov 2023 13:07:46 -0500 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id B5A881C0002; Sun, 19 Nov 2023 18:07:41 +0000 (UTC) In-Reply-To: <878r6tn6uf.fsf@catern.com> (Spencer Baugh's message of "Sun, 19 Nov 2023 14:41:37 +0000 (UTC)") X-GND-Sasl: juri@linkov.net Received-SPF: pass client-ip=2001:4b98:dc4:8::225; envelope-from=juri@linkov.net; helo=relay5-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313008 Archived-At: >>> It sets completions-auto-update to 'deselect by default, which I think >>> is reasonable? >> >> Isn't deselection needed only when minibuffer-visible-completions is enabled? > > I think we could provide some nice consistency by making it always > active. > > As part of this change, I think we should make sure M-RET will submit a > completion candidate even if it's been "deselected". That would be nice > because then M-RET serves a useful purpose with > minibuffer-visible-completions=t: you can submit the previously-selected > completion candidate even if you've typed (causing deselection) since > selecting it. > > With that M-RET behavior, completions-auto-update='deselect doesn't > change behavior from Emacs 29, so I think it's a plausible default. Please note that currently there is no need to use M-RET by default because the default value of minibuffer-completion-auto-choose is t, and M-down inserts the candidate that is accepted by RET. So M-RET could help only in case of minibuffer-visible-completions=t when the editing deselected a completion candidate. > And if we do have completions-auto-update='deselect by default, then > perhaps we can consider another change to the defaults: make RET always > submit the selected completion candidate. That would actually change > behavior, since M- followed *immediately* by RET would submit the > selected completion candidate, but maybe it's worth it? I doubt that any change of the default behavior would be acceptable. >>> * lisp/minibuffer.el (completion--insert): Add a space before each >>> candidate. >> >> I don't think anyone would like such a space shifting the whole layout >> to the right. Rather I'd recommend to use a space after each candidate. >> There is already a space between candidates. Only at the end a space is >> missing. >> >> Or without adding a space at the end we could change `choose-completion` >> to not select the candidate when point is at the end > > Oh, yes, I definitely like the idea of not submitting the candidate when > point is at the end, no need for any extra space. This would work well > with my thought about having M-RET to submitting even a "deselected" > candidate: the new behavior of not submitting a candidate when point is > at the end would only be active for the new command > minibuffer-choose-completion-or-exit. Agreed, so M-RET will override the logic of RET. >> (`choose-completion` needs fixing anyway since currently it raises an >> error at the end of the first completion in case of no header.) >> >> This still won't solve the case of no header. So in this case >> for the initial position we could add a narrow line at the top: >> >> (propertize "\n" 'face '(:height 0)) >> >> This solves a lot of problems, and will help to remove the complicated >> special-handling of the 'first-completion' text property in many places. > > This seems fine to me, but as Eli points out, terminal users probably > won't like the extra "wasted" line. Maybe if we're in the terminal and > there's no header, we could add a single space before the first > completion? A single space the first completion will break the vertical alignment.