From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.bugs Subject: bug#68244: hash-table improvements Date: Sun, 14 Jan 2024 22:08:14 +0000 Message-ID: <86cyu37elt.fsf@gmail.com> References: <170438379722.3921.9312235725296561206@vcs2.savannah.gnu.org> <20240104155642.B4A99C00344@vcs2.savannah.gnu.org> <8d49ebdc-9da7-4e70-a080-d8e892b980b6@gutov.dev> <08314177-5AE9-4352-94A0-641830B4094D@gmail.com> <19265EA5-E6F3-446C-AD9B-763693CF0A48@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="627"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: 68244@debbugs.gnu.org Cancel-Lock: sha1:cAPPjYth/dNPwdwoLjup2Ma9gYI= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 14 23:09:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rP8fR-000AYG-QV for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Jan 2024 23:09:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rP8fA-0001mm-QE; Sun, 14 Jan 2024 17:09:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rP8f9-0001mO-7g for bug-gnu-emacs@gnu.org; Sun, 14 Jan 2024 17:09:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rP8f8-0004fG-VA for bug-gnu-emacs@gnu.org; Sun, 14 Jan 2024 17:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rP8f8-0005fP-93 for bug-gnu-emacs@gnu.org; Sun, 14 Jan 2024 17:09:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Andy Moreton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Jan 2024 22:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68244 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.170527011121718 (code B ref -1); Sun, 14 Jan 2024 22:09:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 14 Jan 2024 22:08:31 +0000 Original-Received: from localhost ([127.0.0.1]:44189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rP8ec-0005eE-PH for submit@debbugs.gnu.org; Sun, 14 Jan 2024 17:08:31 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:48780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rP8eb-0005dy-Fl for submit@debbugs.gnu.org; Sun, 14 Jan 2024 17:08:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rP8eW-0001jX-6n for bug-gnu-emacs@gnu.org; Sun, 14 Jan 2024 17:08:24 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rP8eU-0004JD-Mz for bug-gnu-emacs@gnu.org; Sun, 14 Jan 2024 17:08:23 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1rP8eS-0009GJ-NE for bug-gnu-emacs@gnu.org; Sun, 14 Jan 2024 23:08:20 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278238 Archived-At: On Sat 13 Jan 2024, Mattias Engdegård wrote: > All right, I've pushed the parts that I have little doubt about being a > definite improvement: a batch of refactoring steps, then the hash-table > printing reforms, the representation and growth algorithm improvements, and > finally documentation updates, all now on master. Something in this patch series causes a build failure on Windows using the Mingw64 toolchain. I've tried bisecting this, and at each step doing "git clean -xdf" and then autogen, configure and make for a native build. The last good commit on master is: c3d0cc50faf5 ("Remove rehash-threshold and rehash-size struct members") Bisect identifies this as the bad commit: d3cefd3e9835 ("Leaner hash table dumping and thawing") I have included the end of the log from the failing build below. AndyM -----o0o----- cp -f temacs.exe bootstrap-emacs.exe rm -f bootstrap-emacs.pdmp ./temacs --batch -l loadup --temacs=pbootstrap \ --bin-dest c:/emacs/30.0.50/mingw64-x86_64-O2-native/bin/ --eln-dest c:/emacs/30.0.50/mingw64-x86_64-O2-native/lib/emacs/30.0.50/ Loading loadup.el (source)... Dump mode: pbootstrap Using load-path (c:/emacs/git/emacs/master/lisp c:/emacs/git/emacs/master/lisp/emacs-lisp c:/emacs/git/emacs/master/lisp/progmodes c:/emacs/git/emacs/master/lisp/language c:/emacs/git/emacs/master/lisp/international c:/emacs/git/emacs/master/lisp/textmodes c:/emacs/git/emacs/master/lisp/vc) Loading emacs-lisp/debug-early (source)... ...[snipped]... Loading c:/emacs/git/emacs/master/lisp/emacs-lisp/rmc.el (source)... Finding pointers to doc strings... Finding pointers to doc strings...done Dumping under the name bootstrap-emacs.pdmp Dumping fingerprint: 9f59e49a3ba95f3d7451327de9cf2863b9ddb392220c5f88f384f16245a619c2 Dump complete Byte counts: header=100 hot=16147196 discardable=207320 cold=11360080 Reloc counts: hot=1123689 discardable=5662 ANCIENT=yes make -C ../lisp compile-first EMACS="../src/bootstrap-emacs.exe" make[3]: Entering directory '/c/emacs/git/emacs/master/build/mingw64-x86_64-O2-native/lisp' ELC /c/emacs/git/emacs/master/lisp/emacs-lisp/macroexp.elc C:/emacs/git/emacs/master/src/lisp.h:2564: Emacs fatal error: assertion failed: 0 < size Backtrace: 00007ff722cebc3e 00007ff722b674b1 00007ff722be90dc 00007ff722c33077 00007ff722c26f8a 00007ff722c271e1 00007ff722c28a62 00007ff722c26dc8 00007ff722c271e1 00007ff722c27515 00007ff722c28e7a 00007ff722c267a1 00007ff722c271e1 00007ff722c297a7 00007ff722c26dc8 00007ff722c271e1 00007ff722c27515 00007ff722c28e7a 00007ff722c267a1 00007ff722c271e1 00007ff722c28a62 00007ff722c26dc8 00007ff722c28358 00007ff722c26dc8 00007ff722c5d820 00007ff722c66167 00007ff722c67cd1 00007ff722c26f36 00007ff722c271e1 00007ff722c26dc8 00007ff722c271e1 00007ff722c28a62 00007ff722c26dc8 00007ff722c271e1 00007ff722c28a62 00007ff722c26dc8 00007ff722c29a80 00007ff722c26dc8 00007ff722c271e1 00007ff722c28a62 00007ff722c26dc8 00007ff722c271e1 00007ff722c26dc8 00007ff722c271e1 00007ff722c27515 00007ff722c2269e 00007ff722c67708 00007ff722c67898 00007ff722c22382 00007ff722c3dde8 00007ff722c26f72 00007ff722c5d820 00007ff722c66167 00007ff722c67cd1 00007ff722c26f36 00007ff722c271e1 00007ff722c26dc8 00007ff722c271e1 00007ff722c28a62 00007ff722c26dc8 00007ff722c271e1 00007ff722c28a62 ... make[3]: *** [Makefile:325: /c/emacs/git/emacs/master/lisp/emacs-lisp/macroexp.elc] Error 3 make[3]: Leaving directory '/c/emacs/git/emacs/master/build/mingw64-x86_64-O2-native/lisp' make[2]: *** [Makefile:1017: bootstrap-emacs.pdmp] Error 2 make[2]: Leaving directory '/c/emacs/git/emacs/master/build/mingw64-x86_64-O2-native/src' make[1]: *** [Makefile:554: src] Error 2 make[1]: Leaving directory '/c/emacs/git/emacs/master/build/mingw64-x86_64-O2-native' make[1]: Entering directory '/c/emacs/git/emacs/master/build/mingw64-x86_64-O2-native'