From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68929: [PATCH] Copy which-key from GNU ELPA into core Date: Thu, 08 Feb 2024 08:16:48 +0200 Message-ID: <86cyt7xyy7.fsf@gnu.org> References: <871q9rvqbi.fsf@jeremybryant.net> <86wmrj148c.fsf@gnu.org> <87plx8rkps.fsf@jeremybryant.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24818"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68929@debbugs.gnu.org, monnier@iro.umontreal.ca, justin@burkett.cc To: Jeremy Bryant Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 08 07:17:56 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rXxjQ-0006Es-1M for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Feb 2024 07:17:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rXxjJ-0002qf-W1; Thu, 08 Feb 2024 01:17:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXxjI-0002qT-DL for bug-gnu-emacs@gnu.org; Thu, 08 Feb 2024 01:17:48 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rXxjI-0001nA-4I for bug-gnu-emacs@gnu.org; Thu, 08 Feb 2024 01:17:48 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rXxjW-0000Ul-77 for bug-gnu-emacs@gnu.org; Thu, 08 Feb 2024 01:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Feb 2024 06:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68929 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68929-submit@debbugs.gnu.org id=B68929.17073730341840 (code B ref 68929); Thu, 08 Feb 2024 06:18:02 +0000 Original-Received: (at 68929) by debbugs.gnu.org; 8 Feb 2024 06:17:14 +0000 Original-Received: from localhost ([127.0.0.1]:58839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXxij-0000Tb-IV for submit@debbugs.gnu.org; Thu, 08 Feb 2024 01:17:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXxih-0000TN-BU for 68929@debbugs.gnu.org; Thu, 08 Feb 2024 01:17:12 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXxiM-0001jE-Fh; Thu, 08 Feb 2024 01:16:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ZcXfqqoG3CMSYscFahyQeL6T5zCH74gAVpq38enteks=; b=rlJjxvMxKQyG RV8pX04k0YZkbTmxb9w54h1Stg4HS+AvHa7VSZG/Q3D+mFafAu7nYiEPwlqgjsPIjeH7MakTkA4zf KoqrhRQQjZCfN4jeDCCApMcWpI4HAbauOI83/kv0Us3D7h51BAGj4CMLIX4hEZxlFp4bptUv+7EdD MVkw5nrXqbgNjW7tqx1QxtfeqqHeRdhMfaclobX6Jl28Me/Cyowxq+ykptsMlQrHsl4djn6Held5/ ErpX6fIqrzpsLWWluOSa126GDc8gX8JB0k9suc95kyrkayvxHN1Y7qG3GG5Z3JKymeObBydH9J72B QfxFWW/Sunw//m1uLoJt4w==; In-Reply-To: <87plx8rkps.fsf@jeremybryant.net> (message from Jeremy Bryant on Wed, 07 Feb 2024 22:01:05 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279600 Archived-At: > From: Jeremy Bryant > Cc: 68929@debbugs.gnu.org, monnier@iro.umontreal.ca, justin@burkett.cc > Date: Wed, 07 Feb 2024 22:01:05 +0000 > > > Eli Zaretskii writes: > > Two spaces between sentences in comments and doc strings, here and > > elsewhere. > > OK. Related point - This is not in the Elisp manual "Tips for > documentation strings", is it worth a patch for this? That section is not specific to the Emacs development. Our conventions, which are specific to the Emacs development project, are in CONTRIBUTE. > > Please add a :version tag to all defcustom's and defface's. > > I cannot locate this in the elisp manual, Appendix D "Tips and > conventions", or in the defcustom and defface sections, should this be > documented and how? It's already documented in CONTRIBUTE. Again, other Lisp programs out there are free not to follow these guidelines (and, in fact, :version might not have any useful effect in 3rd party packages), it is our own convention whose purpose is to help "M-x customize-changed" do its job well.