From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68881: 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode' Date: Sat, 10 Feb 2024 21:23:37 +0200 Message-ID: <86cyt4t96u.fsf@gnu.org> References: <83986cee-a32d-707f-6ee0-ec1ba2bd42c2@gmail.com> <86a5ocgp74.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17115"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68881@debbugs.gnu.org, juri@linkov.net To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 10 20:24:57 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rYsy9-0004CN-CK for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Feb 2024 20:24:57 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rYsy0-0007VZ-Vq; Sat, 10 Feb 2024 14:24:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYsxz-0007Tk-7P for bug-gnu-emacs@gnu.org; Sat, 10 Feb 2024 14:24:47 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rYsxy-0007Ck-LC for bug-gnu-emacs@gnu.org; Sat, 10 Feb 2024 14:24:46 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rYsyE-00052b-C6 for bug-gnu-emacs@gnu.org; Sat, 10 Feb 2024 14:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Feb 2024 19:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68881 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68881-submit@debbugs.gnu.org id=B68881.170759304319192 (code B ref 68881); Sat, 10 Feb 2024 19:25:02 +0000 Original-Received: (at 68881) by debbugs.gnu.org; 10 Feb 2024 19:24:03 +0000 Original-Received: from localhost ([127.0.0.1]:35074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYsxH-0004zU-Cp for submit@debbugs.gnu.org; Sat, 10 Feb 2024 14:24:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYsxF-0004yf-4y for 68881@debbugs.gnu.org; Sat, 10 Feb 2024 14:24:01 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYswt-00079X-Cq; Sat, 10 Feb 2024 14:23:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ax5Wi/h3598TMJIq8JKi/YA/xGTpdCgbQOL9AntupYM=; b=pMNeKi+uAyrn qkPgsIxBJemUbdqjtTDlMJFOQlqrK28UkYiKXmjksDxyd+kHzxbw7/jbc5labMFJ3l8MqHxf21NIo akkAI2nT/5o36MbqbROzFEtl+BUx9T5PxDGzT9SGmVrwEJtnUFHEFYcRYQit/3L32IraDSfqlSr4u 00kryHhanlZ8qhV9V+l2qeYscAgK/v1KDUbq6X1eQOkt+W46oGiWj8ut20EDNUcqIvZknt6KxYN/9 827KXA37qL+wDXiGJBL7Zmh1yDcaU6unHwTGNzlsxCI3ChtpKgDMulwh3TW3VK9APgI1ZaHEF1UJd NO+GVGhE5rTM/felj0wRvA==; In-Reply-To: (message from Jim Porter on Sat, 10 Feb 2024 10:22:16 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279790 Archived-At: > Cc: 68881@debbugs.gnu.org > Date: Sat, 10 Feb 2024 10:22:16 -0800 > From: Jim Porter > > On 2/7/2024 9:37 AM, Juri Linkov wrote: > >> The main issue was that outline.el uses 'line-beginning-position' and > >> friends, which respects field boundaries, but I think we want to avoid that > >> for 'outline-minor-mode'. Maybe we could use 'pos-bol' and friends instead, > >> but my understanding is that 'line-beginning-position' respects display > >> directionality (which we probably want), but 'pos-bol' doesn't. > > > > I'm not aware of any cases that would require restricting > > outlines to field boundaries. > > Thanks. After reading the source (generally a good idea), I now see that > 'line-beginning-position' doesn't respect display directionality, so > there's no reason to use it over 'pos-bol' and friends. I've therefore > updated the patch to use those, which makes things a bit simpler. > > (In any case, I think for RTL, we'd want to use the logical ordering of > the text anyway, but possibly add the outline buttons on the right side > of the window instead. That's out of scope for this bug though.) I don't understand what text directionality has to do with the issue at hand. If you elaborate, I could perhaps be of assistance in this matter.