From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 68881@debbugs.gnu.org, juri@linkov.net
Subject: bug#68881: 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode'
Date: Sat, 10 Feb 2024 21:23:37 +0200 [thread overview]
Message-ID: <86cyt4t96u.fsf@gnu.org> (raw)
In-Reply-To: <a80f3421-18cf-6376-5a35-a7978c05f32f@gmail.com> (message from Jim Porter on Sat, 10 Feb 2024 10:22:16 -0800)
> Cc: 68881@debbugs.gnu.org
> Date: Sat, 10 Feb 2024 10:22:16 -0800
> From: Jim Porter <jporterbugs@gmail.com>
>
> On 2/7/2024 9:37 AM, Juri Linkov wrote:
> >> The main issue was that outline.el uses 'line-beginning-position' and
> >> friends, which respects field boundaries, but I think we want to avoid that
> >> for 'outline-minor-mode'. Maybe we could use 'pos-bol' and friends instead,
> >> but my understanding is that 'line-beginning-position' respects display
> >> directionality (which we probably want), but 'pos-bol' doesn't.
> >
> > I'm not aware of any cases that would require restricting
> > outlines to field boundaries.
>
> Thanks. After reading the source (generally a good idea), I now see that
> 'line-beginning-position' doesn't respect display directionality, so
> there's no reason to use it over 'pos-bol' and friends. I've therefore
> updated the patch to use those, which makes things a bit simpler.
>
> (In any case, I think for RTL, we'd want to use the logical ordering of
> the text anyway, but possibly add the outline buttons on the right side
> of the window instead. That's out of scope for this bug though.)
I don't understand what text directionality has to do with the issue
at hand. If you elaborate, I could perhaps be of assistance in this
matter.
next prev parent reply other threads:[~2024-02-10 19:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 23:51 bug#68881: 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode' Jim Porter
2024-02-07 17:37 ` Juri Linkov
2024-02-10 18:22 ` Jim Porter
2024-02-10 19:23 ` Eli Zaretskii [this message]
2024-02-10 21:14 ` Jim Porter
2024-02-11 6:07 ` Eli Zaretskii
2024-02-11 7:08 ` Jim Porter
2024-02-11 17:40 ` Juri Linkov
2024-02-11 18:19 ` Jim Porter
2024-02-12 18:25 ` Juri Linkov
2024-02-13 4:03 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86cyt4t96u.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=68881@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.