From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 4d03f70b7f0 1/4: Correct doc strings for x-*-keysym Date: Sat, 16 Mar 2024 11:10:35 +0200 Message-ID: <86cyru7d9w.fsf@gnu.org> References: <171057401428.10492.2714593846955026456@vcs2.savannah.gnu.org> <20240316072654.D54C4C2BC6B@vcs2.savannah.gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39395"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 16 10:11:33 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rlQ4i-000A3g-RR for ged-emacs-devel@m.gmane-mx.org; Sat, 16 Mar 2024 10:11:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rlQ3t-0002m3-8s; Sat, 16 Mar 2024 05:10:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlQ3r-0002lX-35 for emacs-devel@gnu.org; Sat, 16 Mar 2024 05:10:39 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlQ3q-0005Qh-Qq; Sat, 16 Mar 2024 05:10:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ZkeMoZzykD1QyqKIUKfWiuJjkKgdqV4F/0P/J91h5ZI=; b=pj1tG1+QD2Tg 6bPOOJeJMdMPjVR3s2FoaRw6iANRdzVgxoTsrFR91MOsufwt3+eh84WGSZWhAFulvfO1siLPpvKSR dk1QF5iEZFqZxGfvW09Z0u3w5zwvUpk3XxxzKgtkgSFsPWLQKdn2ECCXp5ezXLYjnq2dl63xwrRYJ RcAEx15kbxxnAXn0yCxCxBqzJdxUcRavOMvI/Nj6mvbkyGSvaVBc9/+JC+rBZ4uKJSp10To2/eHpt kbgCXSk1xEZIwf8korpDUyZ9r9hKivuEuW/45wj99EBO90s1JE43GYFsDZQ0IsFyvDSkUzzv7vsao 16WI1DVWKJxEk/EglgV8XA==; In-Reply-To: <20240316072654.D54C4C2BC6B@vcs2.savannah.gnu.org> (message from Po Lu on Sat, 16 Mar 2024 03:26:54 -0400 (EDT)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317101 Archived-At: > Auto-Submitted: auto-generated > Date: Sat, 16 Mar 2024 03:26:54 -0400 (EDT) > From: Po Lu > > branch: master > commit 4d03f70b7f01477a8d72f827ba8b0dabba8c0a61 > Author: Po Lu > Commit: Po Lu > > Correct doc strings for x-*-keysym > > * src/xterm.c (syms_of_xterm): Clarify whether x-*-keysym > affects the modifier key reported for a keysym or the other way > around. > --- > src/xterm.c | 42 ++++++++++++++++++++++-------------------- > 1 file changed, 22 insertions(+), 20 deletions(-) > > diff --git a/src/xterm.c b/src/xterm.c > index c8a43785564..bebc30c9103 100644 > --- a/src/xterm.c > +++ b/src/xterm.c > @@ -32536,38 +32536,40 @@ Android does not support scroll bars at all. */); > DEFSYM (Qreally_fast, "really-fast"); > > DEFVAR_LISP ("x-ctrl-keysym", Vx_ctrl_keysym, > - doc: /* Which keys Emacs uses for the ctrl modifier. > -This should be one of the symbols `ctrl', `alt', `hyper', `meta', > -`super'. For example, `ctrl' means use the Ctrl_L and Ctrl_R keysyms. > -The default is nil, which is the same as `ctrl'. */); > + doc: /* Which modifer value Emacs reports when Ctrl is depressed. > +This should be one of the symbols `ctrl', `alt', `hyper', `meta', or > +`super', representing a modifier to be reported in key events with the > +Ctrl modifier (i.e. the keysym Ctrl_L or Ctrl_R) depressed. */); > Vx_ctrl_keysym = Qnil; This loses the information about the meaning of the default value of nil, doesn't it? This leaves the user who looks at the default value confused as to what that means. Also, the "depressed" part at the end of the last sentence is not right: a modifier reported in a key event cannot be "depressed", it can only be "set". Right?