From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#68765: 30.0.50; Adding window-tool-bar package. Date: Wed, 27 Mar 2024 09:04:30 +0200 Organization: LINKOV.NET Message-ID: <86cyrg5hc0.fsf@mail.linkov.net> References: <07df5e8408054bcae5968066b0cebf34@finder.org> <86fry0vihy.fsf@gnu.org> <86fry08di9.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2307"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Eli Zaretskii , 68765@debbugs.gnu.org, Philip Kaludercic , Stefan Monnier To: Jared Finder Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 27 08:21:39 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rpNbO-0000TL-GK for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Mar 2024 08:21:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rpNau-0005eu-FG; Wed, 27 Mar 2024 03:21:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rpNas-0005e3-25 for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2024 03:21:06 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rpNar-0002IS-Hx for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2024 03:21:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rpNap-0007BR-Jj for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2024 03:21:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Mar 2024 07:21:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68765 X-GNU-PR-Package: emacs Original-Received: via spool by 68765-submit@debbugs.gnu.org id=B68765.171152405227521 (code B ref 68765); Wed, 27 Mar 2024 07:21:03 +0000 Original-Received: (at 68765) by debbugs.gnu.org; 27 Mar 2024 07:20:52 +0000 Original-Received: from localhost ([127.0.0.1]:35632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rpNad-00079o-ST for submit@debbugs.gnu.org; Wed, 27 Mar 2024 03:20:52 -0400 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:54979) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rpNac-00079D-1h for 68765@debbugs.gnu.org; Wed, 27 Mar 2024 03:20:50 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 7ADEF1C0006; Wed, 27 Mar 2024 07:20:40 +0000 (UTC) In-Reply-To: (Jared Finder's message of "Tue, 26 Mar 2024 08:34:11 -0700") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282124 Archived-At: >>> I'm not sure if this provides a clean interface. >>> Have you tried to show both window-tool-bar and tab-line tabs >>> on the same tab-line? Do you think this combination is usable? >>> Or maybe better just repurpose the tab-line in window-tool-bar.el >>> exclusively for window-local tool-bar? >> The implementation I provided works fine for me with both >> window-tool-bar-mode and tab-line-mode enabled as long as there are not >> too many tabs. I could see further adding a way to specify the max width >> tabs are able to take up if you think that's necessary. > > It's been four weeks and I've seen no reply to this comment. Are there any > other concerns? Sorry, I didn't know that you expected that I should review your patch - I was silent because your last patch has no changes in tab-line.el, so I have no more objections in this regard. As for combining of tabs and the tool-bar on the tab-line, I don't think this is feasible to achieve a consistent solution. So users have to choose only one feature at a time: whether buffer tabs in the tab-line or the window-local tool-bar.