all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Yuan Fu <casouri@gmail.com>
Cc: 71681@debbugs.gnu.org
Subject: bug#71681: 29.3.50; tree-sitter crash
Date: Sun, 30 Jun 2024 19:15:28 +0300	[thread overview]
Message-ID: <86cynyrixj.fsf@mail.linkov.net> (raw)
In-Reply-To: <25A37A53-DD48-4E34-ABD7-1BACECCD8CEC@gmail.com> (Yuan Fu's message of "Sat, 29 Jun 2024 16:54:39 -0700")

> Finally figured out why. It’s not tree-sitter’s problem, but
> ours. I reduced the crash to a signal and pushed the fix to
> emacs-30. Next I’ll make sure the signal is properly handled. Below
> quoting the commit message:
>
> The immediate cause of the crash is that tree-sitter accessed a node's
> tree, but the tree is already deleted.
>
> What happended, I think, is this:
>
> 1. Buffer modified, parser->need_reparse set to true,
> parser->timestamp incremented.
> 2. A node is created from the parser, this node has the old tree but
> the _new_ timestamp (bad!).
> 3. Parser re-parses (treesit_ensure_parsed), new tree created, old
> tree deleted.
> 4. Ftreesit_query_capture accessed the old node, and the old tree,
> crash.
>
> We shouldn't bump the parser timestamp when we set
> parser->need_reparse to true; instead, we should bump the timestamp
> when we actually reparsed and created a new tree.

Thank you very much.  I confirm there are no crashes anymore.





  parent reply	other threads:[~2024-06-30 16:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-20 16:33 bug#71681: 29.3.50; tree-sitter crash Juri Linkov
2024-06-22 23:55 ` Yuan Fu
2024-06-23  5:32   ` Eli Zaretskii
2024-06-23  6:46   ` Juri Linkov
2024-06-23 17:38   ` Juri Linkov
2024-06-24  7:46     ` Yuan Fu
2024-06-26  6:04       ` Yuan Fu
2024-06-29 23:54         ` Yuan Fu
2024-06-30 14:28           ` Vincenzo Pupillo
2024-06-30 16:15           ` Juri Linkov [this message]
2024-06-30 19:22           ` Vincenzo Pupillo
2024-07-01  5:37             ` Yuan Fu
2024-07-01 10:20               ` Vincenzo Pupillo
2024-07-01  6:49           ` Juri Linkov
2024-07-01  7:01             ` Yuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86cynyrixj.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=71681@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.