all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Paul W. Rankin" <rnkn@rnkn.xyz>
Cc: 72521-done@debbugs.gnu.org
Subject: bug#72521: [PATCH]: lisp/help-macro.el: remove hard-coded variable-pitch-mode
Date: Thu, 08 Aug 2024 13:34:00 +0300	[thread overview]
Message-ID: <86cymjmhgn.fsf@gnu.org> (raw)
In-Reply-To: <8DB679E8-6D2A-4935-8118-B4E44B7D6875@rnkn.xyz>

> From: "Paul W. Rankin" <rnkn@rnkn.xyz>
> Date: Thu, 8 Aug 2024 19:57:18 +1000
> Cc: 72521@debbugs.gnu.org
> 
> > On 8 Aug 2024, at 19:45, Eli Zaretskii <eliz@gnu.org> wrote:
> > 
> > Looks good, but I wonder whether a simple boolean user option would be
> > better, and also easier to customize.  After all this is not a mode,
> > so people will not expect it to have a hook.  Also, if someone doesn't
> > want variable-pitch-mode, I doubt they will want some other mode
> > instead, so the hook will most of the time be or the default or nil.
> > 
> > WDYT?
> 
> Agreed. I’ve added `help-for-help-use-variable-pitch’ boolean option. 
> Although it’s a mouthful, I think this name is most discoverable since 
> C-h C-k C-h C-h returns `help-for-help’, and there’s variable 
> `help-for-help-buffer-name’.

Thanks, installed on the emacs-30 release branch, and closing the bug.





  reply	other threads:[~2024-08-08 10:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <9417FE9A-2B7C-4A23-80DE-1322E0ECB812@rnkn.xyz>
2024-08-08  2:25 ` bug#72521: [PATCH]: lisp/help-macro.el: remove hard-coded variable-pitch-mode Paul W. Rankin via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-08  8:58   ` Eli Zaretskii
2024-08-08  9:37     ` Paul W. Rankin via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-08  9:37     ` Paul W. Rankin via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-08  9:45       ` Eli Zaretskii
2024-08-08  9:57         ` Paul W. Rankin via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-08 10:34           ` Eli Zaretskii [this message]
2024-08-08 10:34             ` Paul W. Rankin via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86cymjmhgn.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=72521-done@debbugs.gnu.org \
    --cc=rnkn@rnkn.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.