Re: master 18491f48d97: Install cond*

Re: master 18491f48d97: Install cond*

[pipcet]

"Richard M. Stallman" <rms@gnu.org> writes:

> branch: master
> commit 18491f48d973c9cbc453d9f742ec7f73e83df3bb
> Author: Richard Stallman <rms@gnu.org>
> Commit: Richard Stallman <rms@gnu.org>
>
>     Install cond*
>
>     * oond-star.el: New file.

Would it be okay if I ran whitespace-cleanup on that file? It would make
working with our git pre-commit hooks easier when merging into other
branches, even though I know that cosmetic changes are usually
discouraged. Could we make an exception for this one?

Thanks
Pip

Re: master 18491f48d97: Install cond*

[Arash Esbati]

pipcet@protonmail.com writes:

> "Richard M. Stallman" <rms@gnu.org> writes:
>
>> branch: master
>> commit 18491f48d973c9cbc453d9f742ec7f73e83df3bb
>> Author: Richard Stallman <rms@gnu.org>
>> Commit: Richard Stallman <rms@gnu.org>
>>
>>     Install cond*
>>
>>     * oond-star.el: New file.
>
> Would it be okay if I ran whitespace-cleanup on that file? It would make
> working with our git pre-commit hooks easier when merging into other
> branches, even though I know that cosmetic changes are usually
> discouraged. Could we make an exception for this one?

I suggest to have a look at bug#72546.  It provides a lot of cleanup,
including the whitespace issue.

Best, Arash

Re: master 18491f48d97: Install cond*

[Eli Zaretskii]

> Date: Sun, 11 Aug 2024 14:30:03 +0000
> From: pipcet@protonmail.com
> Cc: "Richard M. Stallman" <rms@gnu.org>
> 
> Would it be okay if I ran whitespace-cleanup on that file?

There's no need to do just whitespace-cleanup because the file had
enough typos to fix whitespace together with them.  Here, done.

Re: master 18491f48d97: Install cond*

[Pip Cet]

"Eli Zaretskii" <eliz@gnu.org> writes:

>> Date: Sun, 11 Aug 2024 14:30:03 +0000
>> From: pipcet@protonmail.com
>> Cc: "Richard M. Stallman" <rms@gnu.org>
>>
>> Would it be okay if I ran whitespace-cleanup on that file?
>
> There's no need to do just whitespace-cleanup because the file had
> enough typos to fix whitespace together with them.  Here, done.

Okay, now you've turned a file with typos and whitespace errors that
prevent committing it to other branches into a file with just whitespace
errors that prevent committing it to other branches.

I'll be bold and fix the remaining whitespace errors.

Pip

Re: master 18491f48d97: Install cond*

[Eli Zaretskii]

> Date: Sun, 11 Aug 2024 16:11:03 +0000
> From: Pip Cet <pipcet@protonmail.com>
> Cc: emacs-devel@gnu.org, rms@gnu.org
> 
> Okay, now you've turned a file with typos and whitespace errors that
> prevent committing it to other branches into a file with just whitespace
> errors that prevent committing it to other branches.

We have anyway files in the repository that have trailing whitespace
which cannot be removed.  That's when the --no-verify switch to Git
commands comes in handy.

IOW, this was a tempest in a teapot.