From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72819: [PATCH] Correctly include fixed strings before a prefix wildcard in PCM Date: Sat, 07 Sep 2024 10:32:24 +0300 Message-ID: <86cylfzzp3.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4119"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72819@debbugs.gnu.org To: Spencer Baugh , monnier@iro.umontreal.ca Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 07 09:33:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1smpwf-0000we-VA for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Sep 2024 09:33:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1smpwO-0006fG-Pp; Sat, 07 Sep 2024 03:33:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smpwN-0006ep-A2 for bug-gnu-emacs@gnu.org; Sat, 07 Sep 2024 03:33:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1smpwN-00075Q-02 for bug-gnu-emacs@gnu.org; Sat, 07 Sep 2024 03:33:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=FIjDm0I+kjod3KQFO6avHD2ZJTz6uLfS2Ol+0QAG/Ow=; b=AfqM3WMxioT+FW5dckZhdS/pyDgdDmO8mgzfdZz8qbKg2nZbu63sjn8bHoBvP4ob6SGLGD5si5ZkZ/AiWkDr1d/A2Ovnhc8ijxQi81vakXXLrAQa9INuQqpM496nucWjE+7Mrn+PduwvKR4pZxpHX9PJrQJj8WjK8GcEtNkumo5e5+9bjltBwvHWQWspvGcVot60vU7zCON9ZMdHyPIT0lDD9ihTOAgdTB/+BgjUka1wDBM2dm4Q6Ip3t/vHLEYT8PhE+mjOM7z4NyVKi2Gsbc+5jsKlcgl/+bF0YtrvQX+Jr2rzgnnEbOV2084Y7MFVNNLenBVuDSHFlrVEmVb93w==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1smpwM-0001BN-EP for bug-gnu-emacs@gnu.org; Sat, 07 Sep 2024 03:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Sep 2024 07:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72819 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72819-submit@debbugs.gnu.org id=B72819.17256943544500 (code B ref 72819); Sat, 07 Sep 2024 07:33:02 +0000 Original-Received: (at 72819) by debbugs.gnu.org; 7 Sep 2024 07:32:34 +0000 Original-Received: from localhost ([127.0.0.1]:54691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smpvt-0001AV-M5 for submit@debbugs.gnu.org; Sat, 07 Sep 2024 03:32:33 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smpvr-0001AF-My for 72819@debbugs.gnu.org; Sat, 07 Sep 2024 03:32:32 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smpvl-00072s-PS; Sat, 07 Sep 2024 03:32:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=FIjDm0I+kjod3KQFO6avHD2ZJTz6uLfS2Ol+0QAG/Ow=; b=MIJ8Or1SXDBO HufSs2ZUuhkwdTSXnYTkVrtwUq3alscoR82dSYbWOPJpkd1EXLFQZ/9yUN4cluRc49ED/+Q3Shv/U HYlGJ6rw+WGgaeJIwQ04QYVhEj/1ptski+Owy1SdTwUIUo3N7/j19JpNhsse7AJ8mXpS+rrZQXT28 jTIVNdYlLVom+FpiiPl9OxDL5tbtbqnJvi3J+eZ/QIKKnKre4uG5F3eszspLaIEgnzGUsO05cimPD lDW+pobfzBve7Y8aL4zAT+zGi6lle78V3OhHwEwrDBKhdCDbXheT59xVrUDWGGjjvjYsLjgn+SZcm 5yD5RHpkeIMdM6g5LBdPgw==; In-Reply-To: (message from Spencer Baugh on Mon, 26 Aug 2024 10:17:05 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291357 Archived-At: Ping! Stefan, any comments? > Cc: monnier@iro.umontreal.ca > From: Spencer Baugh > Date: Mon, 26 Aug 2024 10:17:05 -0400 > > Tags: patch > > > In 63a48252306a631dc07d62d19311433c7877bd27 I fixed a bug with > the PCM implementation of substring completion, relating to the > handling of PCM wildcards. > > However, this fix was incomplete. This change completes the fix by > also including a fixed string if it appears before a `prefix' > wildcard, even if try-completion doesn't discover that fixed string > grows to a unique completion. > > I discovered this bug while working on enhancements to PCM completion > related to completion-pcm-leading-wildcard.