Re: [PATCH] Add file-ring to dired-aux.el

[Eli Zaretskii <eliz@gnu.org>]

> From: Justin Fields <justinlime1999@gmail.com>
> Date: Mon, 21 Oct 2024 05:14:52 -0500
> Cc: emacs-devel@gnu.org
> 
> > Why do you call this a "ring"?  AFAICT, it is a simple list, created
> > and used as such.
> 
> To be perfectly honest, it was just the first thing that came to mind to help distinguish this feature. If anybody
> has any better suggestions I can append accordingly.

Something like dired-marked-files?

> > Why does this use 'concat' instead of 'expand-file-name'?
> The (file-name-nondirectory (directory-file-name file)) in the snippet returns a bare filename. I use concat here
> to set the destination as an identical filename, in the default-directory.

If you use expand-file-name, you will also get correct results.

> > This feature, when installed, will need a NEWS entry.
> I might just not be looking hard enough, but do you have any resources available that I could look into for
> this? :)

Just look at etc/NEWS and see how we announce new features and
commands there.

> > Finally, to accept a contribution of this size we need you to sign the
> > copyright assignment agreement.  Would you like to start this legal
> > paperwork rolling at this time?  If yes, I will send you the form to
> > fill and the instructions to go with it.
> 
> Of course! Very much appreciated. 

Form sent off-list.  Thank you for your interest in Emacs.