From: Eli Zaretskii <eliz@gnu.org>
To: Justin Fields <justinlime1999@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Add file-ring to dired-aux.el
Date: Mon, 21 Oct 2024 13:38:51 +0300 [thread overview]
Message-ID: <86cyjthhac.fsf@gnu.org> (raw)
In-Reply-To: <CAPafesFX16P026UWpm6vJ5HbJtbvm3Djt5m2CWZi-JxWVBfirA@mail.gmail.com> (message from Justin Fields on Mon, 21 Oct 2024 05:14:52 -0500)
> From: Justin Fields <justinlime1999@gmail.com>
> Date: Mon, 21 Oct 2024 05:14:52 -0500
> Cc: emacs-devel@gnu.org
>
> > Why do you call this a "ring"? AFAICT, it is a simple list, created
> > and used as such.
>
> To be perfectly honest, it was just the first thing that came to mind to help distinguish this feature. If anybody
> has any better suggestions I can append accordingly.
Something like dired-marked-files?
> > Why does this use 'concat' instead of 'expand-file-name'?
> The (file-name-nondirectory (directory-file-name file)) in the snippet returns a bare filename. I use concat here
> to set the destination as an identical filename, in the default-directory.
If you use expand-file-name, you will also get correct results.
> > This feature, when installed, will need a NEWS entry.
> I might just not be looking hard enough, but do you have any resources available that I could look into for
> this? :)
Just look at etc/NEWS and see how we announce new features and
commands there.
> > Finally, to accept a contribution of this size we need you to sign the
> > copyright assignment agreement. Would you like to start this legal
> > paperwork rolling at this time? If yes, I will send you the form to
> > fill and the instructions to go with it.
>
> Of course! Very much appreciated.
Form sent off-list. Thank you for your interest in Emacs.
next prev parent reply other threads:[~2024-10-21 10:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 8:11 [PATCH] Add file-ring to dired-aux.el Justin Fields
2024-10-21 9:48 ` Eli Zaretskii
2024-10-21 10:14 ` Justin Fields
2024-10-21 10:38 ` Eli Zaretskii [this message]
2024-10-28 10:31 ` Björn Bidar
[not found] ` <87v7xctt6p.fsf@>
2024-10-28 12:42 ` Eli Zaretskii
2024-10-21 12:35 ` Michael Heerdegen via Emacs development discussions.
2024-10-22 18:15 ` Juri Linkov
2024-10-22 18:43 ` Eli Zaretskii
2024-10-23 6:47 ` Justin Fields
2024-10-22 22:24 ` [External] : " Drew Adams
2024-10-26 7:02 ` Eshel Yaron
2024-10-27 7:47 ` Juri Linkov
2024-10-28 7:16 ` Eshel Yaron
2024-10-28 18:53 ` Juri Linkov
-- strict thread matches above, loose matches on Subject: below --
2024-10-21 15:05 Justin Fields
2024-10-22 15:53 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86cyjthhac.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=justinlime1999@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.