From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74104: 31.0.50; 'custom-set-faces' overrides face when no theme is loaded Date: Sat, 23 Nov 2024 14:13:39 +0200 Message-ID: <86cyimm9l8.fsf@gnu.org> References: <87y125ucbz.fsf@protesilaos.com> <86plnh4n2l.fsf@gnu.org> <87wmhozvfd.fsf@protesilaos.com> <86pln4n2nx.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9176"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74104-done@debbugs.gnu.org To: info@protesilaos.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 23 13:14:27 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tEp1u-0002Fl-Ta for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Nov 2024 13:14:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tEp1e-0000kY-6d; Sat, 23 Nov 2024 07:14:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEp1b-0000ja-BT for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2024 07:14:07 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tEp1W-0004TD-S9 for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2024 07:14:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=nUZaRVmCBYOmGCbKvTf4MClnRs5W7Om1+DgITMBeGPU=; b=v4QX8qh74L5EdodzvB4Cecq/jaSVzQES8fb6FuSPA0D/ofjSWmA46iB2ZMMFSsE5T0+x0+m6BMQ8xmr8LzKA6syWMCBkIcRvVsM8zC29rto7/FBOaRb9Yi8QKdEDKvVZG9m9kQI0nJR8PSQyqnXwZ4IHlvWIcxuHVN5ua4lf4p2p1rw++bMMkN25LolfgIYbMraB4acNO/qCLwFVVN5LLIpIZiRXSzKv2h+e/T1uZXPMSzwkweVly6ChTREVoipumnNbtzWaHwLsqhPekSvslUWESssWt83lxk4/8Ur2akJxSYuByB/v+XY7ycCLrpLPxGA0hT4iXJALZljZkmLDpg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tEp1W-0003ND-NI for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2024 07:14:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Nov 2024 12:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 74104 X-GNU-PR-Package: emacs Mail-Followup-To: 74104@debbugs.gnu.org, eliz@gnu.org, info@protesilaos.com Original-Received: via spool by 74104-done@debbugs.gnu.org id=D74104.173236403112936 (code D ref 74104); Sat, 23 Nov 2024 12:14:02 +0000 Original-Received: (at 74104-done) by debbugs.gnu.org; 23 Nov 2024 12:13:51 +0000 Original-Received: from localhost ([127.0.0.1]:56942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEp1L-0003MZ-E2 for submit@debbugs.gnu.org; Sat, 23 Nov 2024 07:13:51 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEp1J-0003ML-IA for 74104-done@debbugs.gnu.org; Sat, 23 Nov 2024 07:13:50 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEp1B-0004QG-5x; Sat, 23 Nov 2024 07:13:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=nUZaRVmCBYOmGCbKvTf4MClnRs5W7Om1+DgITMBeGPU=; b=UQMs2SHOn53d oUeQtQPUybD+6juh6TFXBHnT9e6gsVTSPRBekB5oIEUa3fdtilkgFxyJVelWs/ag62idOxYKOfalx me5tuqeliGfqwoNhbLjjL2O6AAfTD8bXRl12z+wLzDQ9QFycfAcCFM+dJdMv6K/cG2dRRAKTWp19N AiuiaH/dQT7PgVqoZFfL9kqt9+ELzVxnNfcAXiX3Nirh7vg8gD6CdJh6loxgrIT216/BS4rGYSyAW ruCkjjcOdvNCnhbN5/sNEjaNYo+32qt/Aq7EIbrN5JjCAqMAIvSuw2cASuGrHluF7TdlENyvVO7Kh ADISewvAF+JFT20OSh0lvg==; In-Reply-To: <86pln4n2nx.fsf@gnu.org> (message from Eli Zaretskii on Sat, 09 Nov 2024 12:04:50 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295816 Archived-At: > Cc: 74104@debbugs.gnu.org > Date: Sat, 09 Nov 2024 12:04:50 +0200 > From: Eli Zaretskii > > > From: Protesilaos Stavrou > > Cc: 74104@debbugs.gnu.org > > Date: Thu, 31 Oct 2024 07:35:34 +0200 > > > > > From: Eli Zaretskii > > > Date: Wed, 30 Oct 2024 17:39:30 +0200 > > > > > >> From: Protesilaos Stavrou > > >> Date: Wed, 30 Oct 2024 12:14:40 +0200 > > >> > > >> Dear maintainers, > > >> > > >> When a theme is already enabled, 'custom-set-faces' has the effect of > > >> adding face attributes on top of the existing ones. Those that were > > >> present are not removed: they are blended with the new ones. > > >> > > >> This, however, is not happening when no theme is loaded. In that > > >> scenario, 'custom-set-faces' removes all the underlying face attributes > > >> and keeps only those specified in the function call. I think this is a > > >> mistake. > > > > > > custom-set-faces is used to set up customized faces in the user's init > > > files: they are the forms written by Custom when the user decides to > > > save the face customizations for future sessions. So I don't think > > > this is a mistake, and I don't see how we can change this without > > > catastrophic effects on everyone's init files. > > > > Indeed, I do not want to break anybody's setup or even make far-reaching > > changes just for this. Do you think the difference in behaviour when a > > theme is loaded versus when it is not is the intended design? > > Yes, I think so. No further comments, so I'm now closing this bug.