all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Richard Lawrence <rwl@recursewithless.net>
Cc: 74848@debbugs.gnu.org
Subject: bug#74848: [PATCH] calendar: check for presuppositions in `calendar-date-is-valid-p'
Date: Sat, 14 Dec 2024 13:06:00 +0200	[thread overview]
Message-ID: <86cyhuv813.fsf@gnu.org> (raw)
In-Reply-To: <87o71fpz8j.fsf@ohm.mail-host-address-is-not-set> (message from Richard Lawrence on Fri, 13 Dec 2024 13:02:36 +0100)

> From: Richard Lawrence <rwl@recursewithless.net>
> Date: Fri, 13 Dec 2024 13:02:36 +0100
> 
> Here is a patch to make calendar-date-is-valid-p return nil, instead of
> signaling an error, when it is passed a value that isn't a list of the
> form (MONTH DAY YEAR).
> 
> This (a) makes the function a proper predicate, as its name suggests,
> which (b) is necessary in some of the new iCalendar code I've been
> working on (to be posted soon).

Thanks.

> This is my first time submitting a patch with submit-emacs-patch, so
> please let me know if I did anything wrong.

The commit log message should include the file and the function(s)
where the changes are done, as well as a short description of the
changes.  See CONTRIBUTE for more details, and see "git log" for the
examples of how we format commit log messages.  Please don't forget to
mention the bug number in the commit log message.

P.S. I presume you've run the relevant parts of the test suite and
verified that they still succeed.  If not, please do.





  reply	other threads:[~2024-12-14 11:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-13 12:02 bug#74848: [PATCH] calendar: check for presuppositions in `calendar-date-is-valid-p' Richard Lawrence
2024-12-14 11:06 ` Eli Zaretskii [this message]
2024-12-14 12:19   ` Richard Lawrence
2024-12-14 12:45     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86cyhuv813.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=74848@debbugs.gnu.org \
    --cc=rwl@recursewithless.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.