From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master d7df36e: Rewrite elisp--xref-find-definitions to handle many more cases; add tests. Date: Tue, 11 Aug 2015 18:33:44 -0500 Message-ID: <86bnedxuw7.fsf@stephe-leake.org> References: <20150811025613.30799.89490@vcs.savannah.gnu.org> <55CA1F30.6050402@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1439336060 4646 80.91.229.3 (11 Aug 2015 23:34:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 11 Aug 2015 23:34:20 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 12 01:34:08 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZPJ3U-0006cc-EE for ged-emacs-devel@m.gmane.org; Wed, 12 Aug 2015 01:34:04 +0200 Original-Received: from localhost ([::1]:36141 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPJ3T-0002pO-Ne for ged-emacs-devel@m.gmane.org; Tue, 11 Aug 2015 19:34:03 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPJ3P-0002p6-QD for emacs-devel@gnu.org; Tue, 11 Aug 2015 19:34:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPJ3K-0003xO-7i for emacs-devel@gnu.org; Tue, 11 Aug 2015 19:33:59 -0400 Original-Received: from gproxy8-pub.mail.unifiedlayer.com ([67.222.33.93]:43296) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1ZPJ3K-0003xJ-0H for emacs-devel@gnu.org; Tue, 11 Aug 2015 19:33:54 -0400 Original-Received: (qmail 3525 invoked by uid 0); 11 Aug 2015 23:33:52 -0000 Original-Received: from unknown (HELO cmgw2) (10.0.90.83) by gproxy8.mail.unifiedlayer.com with SMTP; 11 Aug 2015 23:33:52 -0000 Original-Received: from host114.hostmonster.com ([74.220.207.114]) by cmgw2 with id 3bZn1r00j2UdiVW01bZqb1; Tue, 11 Aug 2015 17:33:50 -0600 X-Authority-Analysis: v=2.1 cv=O9qq4nNW c=1 sm=1 tr=0 a=CQdxDb2CKd3SRg4I0/XZPQ==:117 a=CQdxDb2CKd3SRg4I0/XZPQ==:17 a=DsvgjBjRAAAA:8 a=f5113yIGAAAA:8 a=9i_RQKNPAAAA:8 a=y7kgw_RnJtkA:10 a=hEr_IkYJT6EA:10 a=x_XPkuGwIRMA:10 a=uRRa74qj2VoA:10 a=aAd7QSxcqKZH3BuvKGAA:9 Original-Received: from [76.218.37.33] (port=64394 helo=TAKVER2) by host114.hostmonster.com with esmtpa (Exim 4.84) (envelope-from ) id 1ZPJ3F-00029n-IB for emacs-devel@gnu.org; Tue, 11 Aug 2015 17:33:49 -0600 In-Reply-To: (Stefan Monnier's message of "Tue, 11 Aug 2015 12:25:18 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (windows-nt) X-Identified-User: {2442:host114.hostmonster.com:stephele:stephe-leake.org} {sentby:smtp auth 76.218.37.33 authed with stephen_leake@stephe-leake.org} X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 67.222.33.93 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:188740 Archived-At: Stefan Monnier writes: >>> -(defvar elisp--xref-format >>> +(defconst elisp--xref-format >>> (let ((str "(%s %s)")) >>> (put-text-property 1 3 'face 'font-lock-keyword-face str) >>> (put-text-property 4 6 'face 'font-lock-function-name-face str) >>> str)) > >> I'm not sure which part of the change did that, but now I don't see the >> colors in the output. > > I can shed some light here: > - because it's now a defconst, the value is purecopy'd (since > elisp-mode is preloaded). > - purecopy currently doesn't know how to copy string's text properties > so they're just thrown away. > and the better fix would be to improve purecopy to not throw away > those properties. I filed bug#21237 for this. In the meantime, we could at least document this behavior in the defconst docstring. Can we add a warning somewhere in the load/dump process for this? -- -- Stephe