From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nicolas Richard Newsgroups: gmane.emacs.bugs Subject: bug#21931: 25.0.50; behaviour of read-directory-name with double slashes Date: Mon, 16 Nov 2015 07:27:51 +0100 Message-ID: <86bnaue9w8.fsf@members.fsf.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1447710163 13691 80.91.229.3 (16 Nov 2015 21:42:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 16 Nov 2015 21:42:43 +0000 (UTC) To: 21931@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 16 22:42:26 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZyRXX-0004EL-Dj for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Nov 2015 22:42:19 +0100 Original-Received: from localhost ([::1]:50023 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyRXW-0005FQ-PH for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Nov 2015 16:42:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyDHl-0007ig-8n for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2015 01:29:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZyDHi-0003Bj-3f for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2015 01:29:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49721) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyDHi-0003Bf-06 for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2015 01:29:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZyDHh-0001i1-MQ for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2015 01:29:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Nicolas Richard Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Nov 2015 06:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 21931 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.14476553036516 (code B ref -1); Mon, 16 Nov 2015 06:29:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 16 Nov 2015 06:28:23 +0000 Original-Received: from localhost ([127.0.0.1]:39429 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZyDH4-0001h1-FC for submit@debbugs.gnu.org; Mon, 16 Nov 2015 01:28:22 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:59340) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZyDH1-0001gs-6Q for submit@debbugs.gnu.org; Mon, 16 Nov 2015 01:28:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZyDGz-0002fG-Qk for submit@debbugs.gnu.org; Mon, 16 Nov 2015 01:28:18 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:59876) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyDGz-0002fC-Nu for submit@debbugs.gnu.org; Mon, 16 Nov 2015 01:28:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41110) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyDGy-0007W4-NK for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2015 01:28:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZyDGv-0002Yt-H5 for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2015 01:28:16 -0500 Original-Received: from mxin.ulb.ac.be ([164.15.128.112]:43393) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyDGv-0002Yp-Bu for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2015 01:28:13 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AhAIABF3SVakD4XH/2dsb2JhbABehA5vqzECARUBAQEBAQEGBYEIk18Zh3MBAQEBAQGBC0ESAYR4JDQBBIkKmTugGIYNimyEEgWNG4htQI8ChzIzkwVjgUoMAYIuPTSDR4IEAQEB Original-Received: from pno-math-199.ulb.ac.be (HELO Aurora) ([164.15.133.199]) by smtp.ulb.ac.be with ESMTP; 16 Nov 2015 07:27:58 +0100 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108776 Archived-At: After I eval: (let ((default-directory "/tmp")) (list (read-directory-name "foo" "/tmp/src/") (read-directory-name "foo" "/tmp/src//") (read-directory-name "foo" "src/") (read-directory-name "foo" "src//") (read-directory-name "foo" "foo//src/") (read-directory-name "foo" "foo//src//"))) and hit RET RET RET RET, I get : ("/tmp/src/" "/" "src/" "/" "/src/" "/") Is this intended ? We could normalize the directory name via expand-file-name in all cases, e.g. : modified lisp/files.el @@ -648,8 +648,7 @@ read-directory-name (unless dir (setq dir default-directory)) (read-file-name prompt dir (or default-dirname - (if initial (expand-file-name initial dir) - dir)) + (expand-file-name (or initial "") dir)) mustmatch initial 'file-directory-p)) but the docstring states "Value is not expanded---you must call `expand-file-name' yourself." so I guess the behaviour is important (and I guess e.g. for tramp). Should read-file-name be fixed or should the callers make sure to not use double slashes ? In GNU Emacs 25.0.50.1 (i686-pc-linux-gnu, X toolkit, Xaw scroll bars) of 2015-11-14 Repository revision: ed2e7e20ae0945288c98091f308f5460c3453873 Windowing system distributor 'The X.Org Foundation', version 11.0.11501000 System Description: Ubuntu 14.04.3 LTS