* bug#21931: 25.0.50; behaviour of read-directory-name with double slashes
@ 2015-11-16 6:27 Nicolas Richard
2015-11-20 19:19 ` John Wiegley
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Richard @ 2015-11-16 6:27 UTC (permalink / raw)
To: 21931
After I eval:
(let ((default-directory "/tmp"))
(list (read-directory-name "foo" "/tmp/src/")
(read-directory-name "foo" "/tmp/src//")
(read-directory-name "foo" "src/")
(read-directory-name "foo" "src//")
(read-directory-name "foo" "foo//src/")
(read-directory-name "foo" "foo//src//")))
and hit RET RET RET RET, I get :
("/tmp/src/" "/" "src/" "/" "/src/" "/")
Is this intended ?
We could normalize the directory name via expand-file-name in all cases,
e.g. :
modified lisp/files.el
@@ -648,8 +648,7 @@ read-directory-name
(unless dir
(setq dir default-directory))
(read-file-name prompt dir (or default-dirname
- (if initial (expand-file-name initial dir)
- dir))
+ (expand-file-name (or initial "") dir))
mustmatch initial
'file-directory-p))
but the docstring states "Value is not expanded---you must call
`expand-file-name' yourself." so I guess the behaviour is important (and
I guess e.g. for tramp).
Should read-file-name be fixed or should the callers make sure to not
use double slashes ?
In GNU Emacs 25.0.50.1 (i686-pc-linux-gnu, X toolkit, Xaw scroll bars)
of 2015-11-14
Repository revision: ed2e7e20ae0945288c98091f308f5460c3453873
Windowing system distributor 'The X.Org Foundation', version 11.0.11501000
System Description: Ubuntu 14.04.3 LTS
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#21931: 25.0.50; behaviour of read-directory-name with double slashes
2015-11-16 6:27 bug#21931: 25.0.50; behaviour of read-directory-name with double slashes Nicolas Richard
@ 2015-11-20 19:19 ` John Wiegley
2015-11-23 14:14 ` Nicolas Richard
0 siblings, 1 reply; 4+ messages in thread
From: John Wiegley @ 2015-11-20 19:19 UTC (permalink / raw)
To: Nicolas Richard; +Cc: 21931
>>>>> Nicolas Richard <youngfrog@members.fsf.org> writes:
> ("/tmp/src/" "/" "src/" "/" "/src/" "/")
> Is this intended ?
What list were you expecting to see? "//" has always meant "start at root" to
mean, ignoring whatever comes prior. This is how C-x C-f works, and it means
you don't have to delete any existing default text in order to begin at root.
John
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#21931: 25.0.50; behaviour of read-directory-name with double slashes
2015-11-20 19:19 ` John Wiegley
@ 2015-11-23 14:14 ` Nicolas Richard
2015-11-23 20:58 ` Michael Albinus
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Richard @ 2015-11-23 14:14 UTC (permalink / raw)
To: John Wiegley; +Cc: 21931-done
John Wiegley writes:
>>>>>> Nicolas Richard <youngfrog@members.fsf.org> writes:
>
>> ("/tmp/src/" "/" "src/" "/" "/src/" "/")
>> Is this intended ?
>
> What list were you expecting to see? "//" has always meant "start at root" to
> mean, ignoring whatever comes prior. This is how C-x C-f works, and it means
> you don't have to delete any existing default text in order to begin at root.
Indeed, but when constructing a path via (concat foo "/" bar), it can
happen that the result contains //. If this is then used as arg to
read-directory-name, this leads to an unexpected default.
OTOH (info "(elisp) Directory Names") explicitly says that using concat
for constructing paths in this way is wrong, so I guess that this bug
report is void.
Thanks for looking into it, I close it.
Nico.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#21931: 25.0.50; behaviour of read-directory-name with double slashes
2015-11-23 14:14 ` Nicolas Richard
@ 2015-11-23 20:58 ` Michael Albinus
0 siblings, 0 replies; 4+ messages in thread
From: Michael Albinus @ 2015-11-23 20:58 UTC (permalink / raw)
To: 21931; +Cc: youngfrog
Nicolas Richard <youngfrog@members.fsf.org> writes:
>> What list were you expecting to see? "//" has always meant "start at root" to
>> mean, ignoring whatever comes prior. This is how C-x C-f works, and it means
>> you don't have to delete any existing default text in order to begin at root.
>
> Indeed, but when constructing a path via (concat foo "/" bar), it can
> happen that the result contains //. If this is then used as arg to
> read-directory-name, this leads to an unexpected default.
(expand-file-name bar foo) is your choice. If you dislike it, take
(concat (directory-file-name foo) "/" bar)
> Thanks for looking into it, I close it.
>
> Nico.
Best regards, Michael.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-11-23 20:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-16 6:27 bug#21931: 25.0.50; behaviour of read-directory-name with double slashes Nicolas Richard
2015-11-20 19:19 ` John Wiegley
2015-11-23 14:14 ` Nicolas Richard
2015-11-23 20:58 ` Michael Albinus
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.