all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andy Moreton <andrewjmoreton@gmail.com>
To: emacs-devel@gnu.org
Cc: Eli Zaretskii <eliz@gnu.org>
Subject: Crash at startup in Cygwin w32 build on emacs-25 branch
Date: Fri, 27 Nov 2015 00:13:16 +0000	[thread overview]
Message-ID: <86bnagfgf7.fsf@gmail.com> (raw)


The changes in commit d696d62fea48 cause an instant crash at startup for
the cygwin w32 build, as the main Windows thread ID is not initialized.
The following patch fixes it.

diff --git a/src/emacs.c b/src/emacs.c
index c411da6a5da8..48ff20a11ce4 100644
--- a/src/emacs.c
+++ b/src/emacs.c
@@ -760,11 +760,11 @@ main (int argc, char **argv)
      to have non-stub implementations of APIs we need to convert file
      names between UTF-8 and the system's ANSI codepage.  */
   maybe_load_unicows_dll ();
+#endif
   /* This has to be done before module_init is called below, so that
      the latter could use the thread ID of the main thread.  */
   w32_init_main_thread ();
 #endif
-#endif

 #ifdef RUN_TIME_REMAP
   if (initialized)




             reply	other threads:[~2015-11-27  0:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-27  0:13 Andy Moreton [this message]
2015-11-27  8:03 ` Crash at startup in Cygwin w32 build on emacs-25 branch Eli Zaretskii
2015-11-27 23:44   ` Andy Moreton
2015-11-28  8:18     ` Eli Zaretskii
2015-11-28 21:18       ` Andy Moreton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86bnagfgf7.fsf@gmail.com \
    --to=andrewjmoreton@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.