all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stephen Leake <stephen_leake@stephe-leake.org>
To: Ludovic Brenta <ludovic@ludovic-brenta.org>
Cc: 35124@debbugs.gnu.org, ada-mode-users@nongnu.org
Subject: bug#35124: 26.1; ada-mode 6.1.0 no longer syntax-highlights package names at end of spec
Date: Fri, 24 May 2019 08:49:55 -0800	[thread overview]
Message-ID: <86blzrx0ek.fsf@stephe-leake.org> (raw)
In-Reply-To: <bc9e0acd1e83184b4c2008909a64fc39@ludovic-brenta.org> (Ludovic Brenta's message of "Wed, 03 Apr 2019 18:05:17 +0200")

Ludovic Brenta <ludovic@ludovic-brenta.org> writes:

> If you load a file consisting of these three lines:
>
> package Foo is
>    procedure P;
> end Foo;
>
> then the second "Foo" is not syntax-highlighted.  

I can't reproduce this with this small file; font-lock requests that the
entire buffer be parsed, so it is done correctly. With a larger file, so
the start of the package is farther away than the default font-lock
chunk size, the final package name is not highlighted.

This is because the 'end Foo;' is extra text at the end of the partial
parse, and the error recovery inserts 'begin', leaving a labeled block,
in which the label is not highlighted.

If the name has a '.', then it can't be a block label, and it might be
possible to convince the error recovery to insert "package <identifier>
is begin" instead; I'll work on that.

-- 
-- Stephe





  reply	other threads:[~2019-05-24 16:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-03 16:05 bug#35124: 26.1; ada-mode 6.1.0 no longer syntax-highlights package names at end of spec Ludovic Brenta
2019-05-24 16:49 ` Stephen Leake [this message]
2019-08-17 23:27 ` bug#35124: close Stephen Leake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86blzrx0ek.fsf@stephe-leake.org \
    --to=stephen_leake@stephe-leake.org \
    --cc=35124@debbugs.gnu.org \
    --cc=ada-mode-users@nongnu.org \
    --cc=ludovic@ludovic-brenta.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.