all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 64759@debbugs.gnu.org, Mauro Aranda <maurooaranda@gmail.com>
Subject: bug#64759: Broken faces
Date: Fri, 21 Jul 2023 11:13:13 +0300	[thread overview]
Message-ID: <86bkg53cau.fsf@mail.linkov.net> (raw)
In-Reply-To: <83fs5h1z38.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 21 Jul 2023 10:51:55 +0300")

>> This change broke display of `display-time-date-and-time' on the tab-bar:
>>
>>   diff --git a/lisp/time.el b/lisp/time.el
>>   index 522bec46ac6..0184f96fcc2 100644
>>   --- a/lisp/time.el
>>   +++ b/lisp/time.el
>>   @@ -141,6 +141,7 @@ display-time-mail-face
>>    (defface display-time-date-and-time nil
>>      "Face for `display-time-format'."
>>   +  '((t (:inherit mode-line)))
>>      :group 'mode-line-faces
>>      :version "30.1")
>>
>> This face is used by `tab-bar-format-global' that has nothing to do
>> with the mode line, so inheriting from `mode-line' makes no sense.
>
> ??? It is AFAIU used whenever display-time-mode shows the time when
> display-time-day-and-date is non-nil.  Where this is shown doesn't
> matter, and by default this is shown on the mode line.  Thus "makes no
> sense" sounds somewhat harsh to me.

Sorry, I agree it makes sense when shown on the mode line.

> But feel free to change the face definition as you see fit.

It seems adding non-empty definitions in bug#64655
were intended to workaround a bug in cus-edit.el,
not to fix it.

Maybe Mauro could help to fix it (Cc'ed)
without requiring non-nil definitions
that anyway can not be fixed outside of
the Emacs source tree, i.e. in numerous
user init files and external packages.





  reply	other threads:[~2023-07-21  8:13 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-21  6:37 bug#64759: Broken faces Juri Linkov
2023-07-21  7:50 ` Robert Pluim
2023-07-21  8:13   ` Juri Linkov
2023-07-21 10:56     ` Eli Zaretskii
2023-07-21  7:51 ` Eli Zaretskii
2023-07-21  8:13   ` Juri Linkov [this message]
2023-07-21 10:48     ` Mauro Aranda
2023-07-21 16:21       ` Juri Linkov
2023-07-21 16:40         ` Eli Zaretskii
2023-07-21 17:51           ` Juri Linkov
2023-07-21 18:35             ` Eli Zaretskii
2023-07-21 18:49               ` Juri Linkov
2023-07-21 18:55                 ` Eli Zaretskii
2023-07-24 17:35                   ` Juri Linkov
2023-07-24 18:21                     ` Eli Zaretskii
2023-07-25 17:04                       ` Juri Linkov
2023-07-25 17:43                         ` Eli Zaretskii
2023-07-28 17:30                           ` Juri Linkov
2023-07-28 18:49                             ` Eli Zaretskii
2023-07-31 17:42                               ` Juri Linkov
2023-07-31 18:31                                 ` Eli Zaretskii
2023-07-31 20:37                                 ` Mauro Aranda
2023-07-21 10:53     ` Eli Zaretskii
2023-07-21 10:54     ` Eli Zaretskii
2023-07-21 16:20       ` Juri Linkov
2023-07-21 16:39         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86bkg53cau.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=64759@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=maurooaranda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.