From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#69387: 30.0.50; A string shouldn't be both a docstring and a return value Date: Mon, 04 Mar 2024 16:46:58 +0200 Message-ID: <86bk7um4v1.fsf@gnu.org> References: <2D08AD76-59F7-41BE-9363-96677967034A@gmail.com> <4FCE8B7D-17D7-44E8-A764-A6047209CBE1@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23417"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, 69387@debbugs.gnu.org, monnier@iro.umontreal.ca To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 04 15:49:47 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rh9dT-0005pv-67 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Mar 2024 15:49:47 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rh9dL-00053a-Q7; Mon, 04 Mar 2024 09:49:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rh9dG-00050h-6n for bug-gnu-emacs@gnu.org; Mon, 04 Mar 2024 09:49:34 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rh9dF-0007MV-3k for bug-gnu-emacs@gnu.org; Mon, 04 Mar 2024 09:49:33 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rh9di-0007wh-AG for bug-gnu-emacs@gnu.org; Mon, 04 Mar 2024 09:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Mar 2024 14:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69387 X-GNU-PR-Package: emacs Original-Received: via spool by 69387-submit@debbugs.gnu.org id=B69387.170956380130529 (code B ref 69387); Mon, 04 Mar 2024 14:50:02 +0000 Original-Received: (at 69387) by debbugs.gnu.org; 4 Mar 2024 14:50:01 +0000 Original-Received: from localhost ([127.0.0.1]:42705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rh9dg-0007wL-Fq for submit@debbugs.gnu.org; Mon, 04 Mar 2024 09:50:00 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rh9db-0007w1-N2 for 69387@debbugs.gnu.org; Mon, 04 Mar 2024 09:49:59 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rh9at-00073p-13; Mon, 04 Mar 2024 09:47:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=m3KFHRxUbr/ufs790BgLrkwmedATqk4NUIsh/aikujQ=; b=Uc9dVC6HqGI+u4okTmQk dZJTp3DhVlCZm1FbAP8NOOuEnNJ+RiHDDzvMUP46V/32k/KyND1i4zTkXWAsjoQroYbZ0Jfw7VjlQ 5zXBlGygR+uUPIzhaWZ5qEnOCKpFjpaTfFNiM63J1chTTiQoEC7+0BICa46Ns29uVgrVBF+VMIMQi o7Ai8PKFiIGRhrFNzuQSgS37R95URIqhpPN9YuquW0PiBasBSZfmiOdGMtmPhvrtDWOC7DP2swSoB 51Ov28Ye5TRmk4c3uNANIuBf+OxD/eYPkdVkQ03O+5Xdgp5tsnyqQ3x8sg0DAcHNuWwnHqub3ZWdS YOZOPhDsS0tTDA==; In-Reply-To: (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Mon, 4 Mar 2024 15:28:51 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281012 Archived-At: > From: Mattias Engdegård > Date: Mon, 4 Mar 2024 15:28:51 +0100 > Cc: Eli Zaretskii , > 69387@debbugs.gnu.org, > Philip Kaludercic > > > I agree. I'll make a patch for the warning, just so that we can see what it would look like. > > Here, belatedly. It includes the lambda string change. The warning includes `defun` and `defmacro` but not plain lambdas. > > Removing doc strings from ambiguous lambdas didn't break anything, as expected. I think the warning makes sense, because it does expose some mistakes where doc strings were returned but shouldn't be, or returned strings also exposed as (nonsensical) doc strings. > > There are quite a few cl-defmethod forms with this syndrome but those definitions never were ambiguous (the strings are always a return value, never doc string). Do we need to say something about this change in NEWS?