From: Eli Zaretskii <eliz@gnu.org>
To: "Mattias Engdegård" <mattias.engdegard@gmail.com>
Cc: philipk@posteo.net, 69387@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#69387: 30.0.50; A string shouldn't be both a docstring and a return value
Date: Mon, 04 Mar 2024 16:46:58 +0200 [thread overview]
Message-ID: <86bk7um4v1.fsf@gnu.org> (raw)
In-Reply-To: <D9CC859E-0D76-497A-9794-980FC10176A9@gmail.com> (message from Mattias Engdegård on Mon, 4 Mar 2024 15:28:51 +0100)
> From: Mattias Engdegård <mattias.engdegard@gmail.com>
> Date: Mon, 4 Mar 2024 15:28:51 +0100
> Cc: Eli Zaretskii <eliz@gnu.org>,
> 69387@debbugs.gnu.org,
> Philip Kaludercic <philipk@posteo.net>
>
> > I agree. I'll make a patch for the warning, just so that we can see what it would look like.
>
> Here, belatedly. It includes the lambda string change. The warning includes `defun` and `defmacro` but not plain lambdas.
>
> Removing doc strings from ambiguous lambdas didn't break anything, as expected. I think the warning makes sense, because it does expose some mistakes where doc strings were returned but shouldn't be, or returned strings also exposed as (nonsensical) doc strings.
>
> There are quite a few cl-defmethod forms with this syndrome but those definitions never were ambiguous (the strings are always a return value, never doc string).
Do we need to say something about this change in NEWS?
next prev parent reply other threads:[~2024-03-04 14:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-25 16:29 bug#69387: 30.0.50; A string shouldn't be both a docstring and a return value Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-25 17:13 ` Eli Zaretskii
2024-02-25 18:23 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-25 17:33 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-26 14:47 ` Philip Kaludercic
2024-02-26 17:15 ` Mattias Engdegård
2024-02-26 17:44 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-26 18:04 ` Mattias Engdegård
2024-02-26 18:17 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-26 19:06 ` Mattias Engdegård
2024-03-04 14:28 ` Mattias Engdegård
2024-03-04 14:46 ` Eli Zaretskii [this message]
2024-03-05 13:16 ` Mattias Engdegård
2024-03-05 15:38 ` Eli Zaretskii
2024-03-06 11:44 ` Mattias Engdegård
2024-03-07 14:06 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86bk7um4v1.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=69387@debbugs.gnu.org \
--cc=mattias.engdegard@gmail.com \
--cc=monnier@iro.umontreal.ca \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.