From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#69983: Use category for display-buffer-alist Date: Wed, 27 Mar 2024 09:15:19 +0200 Organization: LINKOV.NET Message-ID: <86bk7040vo.fsf@mail.linkov.net> References: <86h6gv7e0z.fsf@mail.linkov.net> <3e7b8e64-0a5f-4888-a443-9c69a5fffd98@gmx.at> <86bk72dze6.fsf@mail.linkov.net> <69163329-d756-4747-9496-dd59e3c61c83@gmx.at> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2981"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 69983@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 27 08:21:45 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rpNbV-0000e0-NI for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Mar 2024 08:21:45 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rpNau-0005ev-F8; Wed, 27 Mar 2024 03:21:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rpNas-0005eG-GA for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2024 03:21:06 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rpNas-0002Ic-5m for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2024 03:21:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rpNar-0007C0-Uz for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2024 03:21:05 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Mar 2024 07:21:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69983 X-GNU-PR-Package: emacs Original-Received: via spool by 69983-submit@debbugs.gnu.org id=B69983.171152406427624 (code B ref 69983); Wed, 27 Mar 2024 07:21:05 +0000 Original-Received: (at 69983) by debbugs.gnu.org; 27 Mar 2024 07:21:04 +0000 Original-Received: from localhost ([127.0.0.1]:35640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rpNao-0007B4-Ik for submit@debbugs.gnu.org; Wed, 27 Mar 2024 03:21:03 -0400 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:55193) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rpNai-00079g-IT for 69983@debbugs.gnu.org; Wed, 27 Mar 2024 03:20:57 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id B2DEA40006; Wed, 27 Mar 2024 07:20:49 +0000 (UTC) In-Reply-To: <69163329-d756-4747-9496-dd59e3c61c83@gmx.at> (martin rudalics's message of "Tue, 26 Mar 2024 10:55:47 +0100") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282125 Archived-At: >> Ok, but before proceeding I propose the following change. > > Would this imply a change in 'buffer-match-p'? Indeed, here it a simple change in 'buffer-match-p' that will support this case: (add-to-list 'display-buffer-alist `((category . comint) (display-buffer-in-direction) (direction . top))) (display-buffer (get-buffer-create "blablabla") '(nil (category . comint))) diff --git a/lisp/subr.el b/lisp/subr.el index b68aa073ba0..2d104c545f0 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -7502,6 +7502,8 @@ buffer-match-p (push condition buffer-match-p--past-warnings)) (apply condition buffer-or-name (if args nil '(nil))))))) + (`(category . ,category) + (eq (alist-get 'category (car args)) category)) (`(major-mode . ,mode) (eq (buffer-local-value 'major-mode buffer)