From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 72097@debbugs.gnu.org
Subject: bug#72097: 30.0.60; [PATCH] Don't add to Eshell history when aborting 'eshell-command'
Date: Sun, 14 Jul 2024 07:42:29 +0300 [thread overview]
Message-ID: <86bk30k2iy.fsf@gnu.org> (raw)
In-Reply-To: <d9e9ffd8-0f1a-d57f-e40d-cac46d7c88e1@gmail.com> (message from Jim Porter on Sat, 13 Jul 2024 11:51:46 -0700)
> Date: Sat, 13 Jul 2024 11:51:46 -0700
> From: Jim Porter <jporterbugs@gmail.com>
>
> emacs -Q
> M-x eshell-command RET oops C-g
> M-x eshell
> <up>
>
> This will show the most-recent command in the Eshell history as "oops".
> That's because it was adding to the history in 'minibuffer-exit-hook',
> which runs regardless of *how* you exit the minibuffer. This regressed
> from 093a360251, and I misunderstood the conditions where
> 'minibuffer-exit-hook' runs.
>
> Attached is a patch to fix this. Is this ok for the release branch?
Yes, thanks.
next prev parent reply other threads:[~2024-07-14 4:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-13 18:51 bug#72097: 30.0.60; [PATCH] Don't add to Eshell history when aborting 'eshell-command' Jim Porter
2024-07-14 4:42 ` Eli Zaretskii [this message]
2024-07-15 16:12 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86bk30k2iy.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=72097@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.