From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72193: 31.0.50; DocView on Postscript with SVG support Date: Sun, 21 Jul 2024 10:27:06 +0300 Message-ID: <86bk2rciid.fsf@gnu.org> References: <87msmd4l8h.fsf@ledu-giraud.fr> <86sew4edrm.fsf@gnu.org> <878qxvajxk.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24653"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72193-done@debbugs.gnu.org, manuel@ledu-giraud.fr To: Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 21 09:28:27 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sVQzb-0006GW-8H for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Jul 2024 09:28:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sVQzD-0003H0-F3; Sun, 21 Jul 2024 03:28:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sVQzC-0003Cp-7l for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2024 03:28:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sVQzA-0001fA-UY for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2024 03:28:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sVQzC-0007Mc-2S for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2024 03:28:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Jul 2024 07:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 72193 X-GNU-PR-Package: emacs Mail-Followup-To: 72193@debbugs.gnu.org, eliz@gnu.org, manuel@ledu-giraud.fr Original-Received: via spool by 72193-done@debbugs.gnu.org id=D72193.172154683928242 (code D ref 72193); Sun, 21 Jul 2024 07:28:01 +0000 Original-Received: (at 72193-done) by debbugs.gnu.org; 21 Jul 2024 07:27:19 +0000 Original-Received: from localhost ([127.0.0.1]:54677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVQyV-0007LR-3p for submit@debbugs.gnu.org; Sun, 21 Jul 2024 03:27:19 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVQyT-0007LC-7h for 72193-done@debbugs.gnu.org; Sun, 21 Jul 2024 03:27:18 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sVQyM-0001bZ-7J; Sun, 21 Jul 2024 03:27:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GqhE7jjHnm8DmDiptssjwabqjWvgPLMVWsy8pTCoUik=; b=IEdgcGhQSsLu aBWcJrk7E5r0m9tpCxKch52t45pyXvDn9IvRZzgnhnpMOSlT9LLq2eNvRF7q7SnjwBAoR1vGBnUs3 pqQv8QsNiAqjCtLZ5Re+P2NMBYZGADwjRD2/9spRPtzap83I44o2MKKv2ZlwLbyLI6eHFcXZs2kBf PcPbp+snlfpcUAGy6W24czfjyIL3ZCFRNXtdGIfRae0lSXJd2aj5fair59dyv9OUlsPAUY6QQ4nHy f7x4FuLVEK/tydJdkQpcF5kzHyCdEUH0Z1A7hoZG1H70JliNiOK24W2RSoMHFzGZitBPml/r6dv1M B1n7qjQrCLQpXcj+6+qLxw==; In-Reply-To: <878qxvajxk.fsf@gnu.org> (message from Tassilo Horn on Sat, 20 Jul 2024 22:27:03 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289060 Archived-At: > From: Tassilo Horn > Cc: Manuel Giraud , 72193@debbugs.gnu.org > Date: Sat, 20 Jul 2024 22:27:03 +0200 > > Eli Zaretskii writes: > > Hi Manuel & Eli, > > >> Looking for pages into the cache with `doc-view-dired-cache', it > >> seems that DocView has produced PNG content into files with "svg" > >> extension. Emacs then tries to display SVG images with PNG content > >> and, obviously, failed. > >> > >> The following patch fixes the issue for me but maybe there is more than > >> meets the eye: > >> > >> diff --git a/lisp/doc-view.el b/lisp/doc-view.el > >> index f96b1bad886..e3539f8f886 100644 > >> --- a/lisp/doc-view.el > >> +++ b/lisp/doc-view.el > >> @@ -2151,6 +2151,7 @@ doc-view-set-up-single-converter > >> (pcase-let ((`(,conv-function ,type ,extension) > >> (pcase doc-view-doc-type > >> ('djvu (list #'doc-view-djvu->tiff-converter-ddjvu 'tiff "tif")) > >> + ((or 'ps 'postscript 'eps) (list #'doc-view-ps->png-converter-ghostscript 'png "png")) > >> (_ (if (and (eq doc-view-pdf->png-converter-function > >> #'doc-view-pdf->png-converter-mupdf) > >> doc-view-mupdf-use-svg) > > > > Tassilo, any comments or suggestions? > > The patch is absolutely correct. That's been an oversight, I think. > Thanks Manuel! Thanks, now installed on the emacs-30 branch, and closing the bug.