From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72156: 31.0.50; defcustom set issue Date: Sun, 04 Aug 2024 10:38:42 +0300 Message-ID: <86bk28u48t.fsf@gnu.org> References: <87le206x0k.fsf.ref@aol.com> <87le206x0k.fsf@aol.com> <86le1we9aw.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17256"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72156@debbugs.gnu.org, Stephen Berman To: spacibba@aol.com, maurooaranda@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 04 09:40:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1saVqb-0004Le-Gk for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Aug 2024 09:40:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1saVqC-0003M1-D7; Sun, 04 Aug 2024 03:39:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1saVq9-0003Le-V0 for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2024 03:39:42 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1saVq9-00074B-L9 for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2024 03:39:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=v1o6ioM0VtfFyZzgoC6hgaatW3wFyAHnDNIEPkNfFXE=; b=C6sOjToKjOAvAvJ/Ln1TmIkUs++isfiNw3niqLo3qEAePcontdvGvPEEHOOdFz4NfhzlyDEjM8jZJb00yvRRw9IQ7tqZIMuvpKwbjivJMfnzWAVKrrtHEDMiCqDR7V6ODjOUmWYinuPM1j69AuBrCxLtS4xoUAWagqhFY0GplhwBrnHe+b7/qWmX20/NGms24fYiGCkfP0vSU3olP1tDbn09DpFQIOg/Q2Km3LyhuN3+SanbDEhzB5Mdh4hpIBTuDZySTBAPaLrvPcYd1REn1y6IpYikN4gK2tn4HfPSqcvp/4NNBzZQ7U+jKp4O1BN0mLJ1T4zqJFs5/+37OUdj8w==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1saVqT-0004BO-Sg for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2024 03:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Aug 2024 07:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72156 X-GNU-PR-Package: emacs Original-Received: via spool by 72156-submit@debbugs.gnu.org id=B72156.172275715515947 (code B ref 72156); Sun, 04 Aug 2024 07:40:01 +0000 Original-Received: (at 72156) by debbugs.gnu.org; 4 Aug 2024 07:39:15 +0000 Original-Received: from localhost ([127.0.0.1]:55346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saVpi-000498-IB for submit@debbugs.gnu.org; Sun, 04 Aug 2024 03:39:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saVpg-00048a-Dp; Sun, 04 Aug 2024 03:39:13 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1saVpF-0006sI-Ar; Sun, 04 Aug 2024 03:38:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=v1o6ioM0VtfFyZzgoC6hgaatW3wFyAHnDNIEPkNfFXE=; b=eL44wtJqrhPo nEbEqbKxI2nmaO8wbunhZrd+1pfN15FmJaan867SlqsarGnR2RxmSIU/kpyxlz+d8pkwbsciZjIf5 WkfLQ5IEhxiPzJWym5VgLJEKpgvtxZB2xkCBEPCpgskCqp8PA1G1eZjgkReeJ9S2ltTXKbp9XG1Uw MTdMQiMItXDFjLh0m3INVSdpdj2lEJc8aMbIPLNfy8ebA8h3TLlQb7/1jk5Dqr3s19h7Y3EMWJFO4 CJqQfmD7VrDxRT0QAEGNTUkcbauhwn+BQ6yYRjWxyGMJ+8DSIKr+krlUhcv0jVqb7j/sGljkPgZBo rUNM/Asa4l2N61FlUIpV7Q==; In-Reply-To: <86le1we9aw.fsf@gnu.org> (message from Eli Zaretskii on Sat, 20 Jul 2024 11:50:47 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289712 Archived-At: merge 72156 72404 thanks > Cc: 72156@debbugs.gnu.org > Date: Sat, 20 Jul 2024 11:50:47 +0300 > From: Eli Zaretskii > > > Date: Wed, 17 Jul 2024 14:08:59 +0200 > > From: Ergus via "Bug reports for GNU Emacs, > > the Swiss army knife of text editors" > > > > I have this defcustom: > > > > ``` > > (defcustom gtags-mode-features '(control meta) > > "HELLO WORLD" > > :type '(set (const control) > > (const meta) > > (const shift) > > (const hyper) > > (const super) > > (const alt))) > > ``` > > > > When I try the customize-variable I get this: > > > > ``` > > Hide Gtags Mode Features: > > Set: > > [X] control > > [X] meta > > [ ] shift > > [ ] hyper > > [ ] super > > [ ] alt > > [ State ]: EDITED, shown value does not take effect until you set or save it. > > HELLO WORLD > > Groups: [Gtags Mode] > > ``` > > > > But, if I do the next change and save > > > > > > ``` > > Hide Gtags Mode Features: > > Set: > > [X] control > > [X] meta > > [X] shift > > [ ] hyper > > [ ] super > > [ ] alt > > [ State ]: EDITED, shown value does not take effect until you set or save it. > > HELLO WORLD > > Groups: [Gtags Mode] > > ``` > > > > The customize variable value saved is: > > > > '(gtags-mode-features3 '(shift)) > > > > it only saved the "new" value and ignores the previous > > existing ones. > > > > When I restart and check the variable's value I get as expected '(shift) > > and lost the control and meta. > > > > Going to customize-variable again I get: > > > > ``` > > Hide Gtags Mode Features: > > Set: > > [ ] control > > [ ] meta > > [X] shift > > [ ] hyper > > [ ] super > > [ ] alt > > [ State ]: EDITED, shown value does not take effect until you set or save it. > > HELLO WORLD > > Groups: [Gtags Mode] > > ``` > > > > Consistent with the variable value, but inconsistent with what was > > actually saved before. > > > > IF instead of selecting a new value I un-select some, then variable > > saves nil and will be nil. > > This seems to be some bug in handling the 'set' type of defcustoms. I > see the same problem when customizing completions-merging-modes from > completion.el. Perhaps Mauro (CC'ed) could chime in and suggest how > to solve this. This actually seems to be the same problem as bug#72404, since the fix proposed by Stephen there fixes this one as well. So I'm merging them.