From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72526: 31.0.50; [PATCH] Fix url-basic-auth secret search when passing username and/or port Date: Sat, 17 Aug 2024 09:02:19 +0300 Message-ID: <86bk1r661g.fsf@gnu.org> References: <87bk1stevo.fsf@> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10435"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72526@debbugs.gnu.org To: =?UTF-8?Q?Bj=C3=B6rn?= Bidar Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 17 08:03:47 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sfCXT-0002av-1E for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Aug 2024 08:03:47 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sfCX8-0000on-5X; Sat, 17 Aug 2024 02:03:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sfCX6-0000oF-Eh for bug-gnu-emacs@gnu.org; Sat, 17 Aug 2024 02:03:24 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sfCX6-0001Ub-5X for bug-gnu-emacs@gnu.org; Sat, 17 Aug 2024 02:03:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=xeO98z5cqec6O89Qp5E/GFunhqAUMrpPlDBiuWzTkuA=; b=k3lJm/8B3oda9vcG512FRG1a3ZbzXZQH1qvVz1foomlTrLXggFMxdVhBDSku5CR3wPYGyhyPgu9sfOUP6JGUidQwJU1uyfriFzD5ki/B+D2hRj79RpG6V+f3/tps1k9NyZEWgKMs0H9hkDI1VvzhHO6YVLE1ToDYr7QSilC3zV6OygmX9GeKYJX2IdacrecKR+/3fTkGzz1v0ALWiWXy1tphnE/p/nqbvwEzn6MrkQmMPWshULJG9At+DiHtwxVcewoTMd/e8jvOQ1l044b+DEX2OcIFCWmCOgb2RF0qYRx9rGNHVvWwcDqQ3nBnarb62Pv8SWfdb8RjrgQkCK/B7A==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sfCXi-00058Q-AQ for bug-gnu-emacs@gnu.org; Sat, 17 Aug 2024 02:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Aug 2024 06:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72526 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72526-submit@debbugs.gnu.org id=B72526.172387458819670 (code B ref 72526); Sat, 17 Aug 2024 06:04:02 +0000 Original-Received: (at 72526) by debbugs.gnu.org; 17 Aug 2024 06:03:08 +0000 Original-Received: from localhost ([127.0.0.1]:53256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfCWp-00057C-Mc for submit@debbugs.gnu.org; Sat, 17 Aug 2024 02:03:07 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfCWo-00056h-3P for 72526@debbugs.gnu.org; Sat, 17 Aug 2024 02:03:06 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sfCW6-0001RH-0c; Sat, 17 Aug 2024 02:02:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=xeO98z5cqec6O89Qp5E/GFunhqAUMrpPlDBiuWzTkuA=; b=p4oJCDET0+XFStrlivfi pKzBFzsqk3bMSXS+2wZyaoKWKrKcU0nU8H4gdVjBvvmdZNPk2nLpZqtmUo2Y1xMukHy7DIJUIEszC W2l5hYGtCKGhTgf/3p/Lbperp/9gucpX/t3mS04UTV7+NJeQZc/r8cy8BGC9O2zUhenhdOXJwEK51 Bf2tKKlkI+sr1av41kOvAsKHnZrMpvrJjlf9UnP/4Is/KBFWiqb2VUW+KSGkPbAVWj8aLq4VS0/2y jmUHNLUKbqTAELePeR5ldCdPgRy7glKJwohrQEKN37Vk+J/4ahJe4R+LnocF+lnm0SjvNManGeWYE AkfcwEph9uyUyw==; In-Reply-To: <87bk1stevo.fsf@> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290213 Archived-At: > Date: Fri, 16 Aug 2024 23:02:51 +0300 > From: Björn Bidar via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Could someone please review my patch? Sorry, I don't see any experts around to ask to do that. Maybe if you'd posted a more detailed description of the problem and its context, someone could follow your arguments and do a meaningful review. E.g., it sounds from your description like the case of URLs where it currently fails was not meant to be supported by this library? If so, perhaps an alternative is to submit to this library only URLs that it supports, like after stripping the port part? On another level: please make sure you leave 2 spaces between sentences in comments, strings, and commit log messages. And I don't think the 3rd patch belongs to this issue, so let's not include it in this discussion. Thanks.