From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65380: [PATCH] Add command to copy contents in a diff-mode buffer Date: Tue, 20 Aug 2024 16:09:00 +0300 Message-ID: <86bk1nwdcj.fsf@gnu.org> References: <87wmxrwe6h.fsf@posteo.net> <83o7j3z4wm.fsf@gnu.org> <87pm3jwboc.fsf@posteo.net> <83lee7z3xs.fsf@gnu.org> <87jztrvxx2.fsf@posteo.net> <83r0nyyhlz.fsf@gnu.org> <86o7j2qgmc.fsf@mail.linkov.net> <83cyzhwpcj.fsf@gnu.org> <87a5ultvuy.fsf@posteo.net> <83a5ulwos6.fsf@gnu.org> <87fs4bgwuj.fsf@posteo.net> <83fs4btiw1.fsf@gnu.org> <871q2n152u.fsf@posteo.net> <87frr1zw6i.fsf@posteo.net> <864j7hzviv.fsf@gnu.org> <87bk1pztsr.fsf@posteo.net> <861q2lzp70.fsf@gnu.org> <87ed6kxq5j.fsf@posteo.net> <86le0rwhlx.fsf@gnu.org> <87y14rv1ie.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4263"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65380@debbugs.gnu.org, juri@linkov.net To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 20 15:10:49 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sgOdM-0000wd-Pk for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 20 Aug 2024 15:10:49 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sgOdA-0006zQ-LI; Tue, 20 Aug 2024 09:10:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgOct-0006xZ-6P for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2024 09:10:20 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sgOcs-0005Yz-TS for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2024 09:10:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=g/JgjktHRVu5pwDMTc9AttvbbUco49wrAbzvKEaR1hU=; b=KX0w3a5CmIMjgr27ZxPcSm4Im+amCy2hWoycZS1LMcA9K4mns6ckOG7FkAIpd4QaGkuJZfe+T4ctJ64Ws/6XlgGPxZ9XR++tf0g6k4XAFxsRoYc+FGag/dczICG7TX+wmJg2ZInlIcrBwOt19+YQ5SLqtjv0cGG0MVPSb2n7vmaHT4wqTR1otMfKtRUYDoZPu3esmI/VOzKh9YPXG/kiuFVslyHIOdBkKzri7veIDqsoTu4lWRAHe6mCeuE0WZm7ygj2yDjzXU9m6w9N5bclYLVg+6MO77N3GGFYQCrvj+WP96sOhcAh1PlSJgVIg1mkFfGxMcEOyGoyBktk1ervqg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sgOdZ-0001Wt-KZ for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2024 09:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Aug 2024 13:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65380 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65380-submit@debbugs.gnu.org id=B65380.17241594025794 (code B ref 65380); Tue, 20 Aug 2024 13:11:01 +0000 Original-Received: (at 65380) by debbugs.gnu.org; 20 Aug 2024 13:10:02 +0000 Original-Received: from localhost ([127.0.0.1]:60049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgOcb-0001VN-Sl for submit@debbugs.gnu.org; Tue, 20 Aug 2024 09:10:02 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgOcU-0001Ui-CG for 65380@debbugs.gnu.org; Tue, 20 Aug 2024 09:10:00 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgObh-0005Fx-Ho; Tue, 20 Aug 2024 09:09:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=g/JgjktHRVu5pwDMTc9AttvbbUco49wrAbzvKEaR1hU=; b=oyltD8u4Lj48 h1YG+9itej0gZiK2eaYMeoWq/jn+WkHu6j5ZAVcbbSROif4feiM0xxADb6xRpRnoVtsdxlvug++LD snOzcmELBoG0Iy6svXAamJdxo/0MExK4iy2alqQ0HqCivbHB10ZopryI/bpd0gOpPC+J3w7p03wyr x7n5DRVf/UHnwhAMU75mduhXghimSpfGfAvQdwsvJiZOwcLpgr3GJpENjM9BoKcQnHGwAqRO5wMaj k1yzsTSyHkfTOzUthe9BUw8qYvLmZotGI/xQINCkCFPu5ICWK2o2dxauUiv70WkRc+GHDXyfxxei6 8/7hPaDc/MYvvDq/+YetFw==; In-Reply-To: <87y14rv1ie.fsf@posteo.net> (message from Philip Kaludercic on Tue, 20 Aug 2024 12:10:01 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290443 Archived-At: > From: Philip Kaludercic > Cc: juri@linkov.net, 65380@debbugs.gnu.org > Date: Tue, 20 Aug 2024 12:10:01 +0000 > > Eli Zaretskii writes: > > >> If the selected range extends a hunk, the > >> +commands attempts to look up and copy the text between from the > >> +referenced file. ^^^^^^^^^^^^^^^^^ > > > > Something is missing (or redundant) in this sentence. > > How about "the text in between from". Does that sound better? > ^^ If that's what you mean, I suggest "the text in-between the hunks". > >> +By default the command will copy the text that applying the diff would > >> +produce, along with the text between hunks. If REVERSE is non-nil, or > >> +the command was invoked with a prefix argument, copy the deleted text." > > > > The "deleted text" part here is unclear: who or what deletes text and > > what text is deleted? > > I want to express that it copies the parts of the diff, that the > changeset removes (lines beginning with "-"). So perhaps "... copy the text > removed in the diff" would be better? I think "copy the text removed by the diffs", and perhaps say explicitly that those are the lines in the hunks preceded with "-".