all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: George Huebner <george@feyor.sh>
Cc: 72848-done@debbugs.gnu.org
Subject: bug#72848: [PATCH RESEND] xwidget: Fix xwidget-at misinterpreting non-xwidget text-properties
Date: Thu, 29 Aug 2024 15:13:58 +0300	[thread overview]
Message-ID: <86bk1bfrw9.fsf@gnu.org> (raw)
In-Reply-To: <m2bk1da26n.fsf@feyor.sh> (message from George Huebner on Tue, 27 Aug 2024 20:03:44 -0500)

> From: George Huebner <george@feyor.sh>
> Date: Tue, 27 Aug 2024 20:03:44 -0500
> 
> xwidget-at assumes the text-property at `point-min` either doesn't
> exist or is an xwidget, and can improperly access fields. This 
> patch
> just returns nil if the text-property isn't an xwidget.
> 
> This is definitely an edge case; I use a package called org-modern
> where headlines are formatted with text-properties, which is how I
> found the bug:
> Debugger entered--Lisp error: (wrong-type-argument listp #("◉" 0 1
> (face org-modern-symbol)))
>  xwidget-at(1)
>  xwidget-webkit-current-session()

Thanks, installed on the emacs-30 branch, and closing the bug.





      reply	other threads:[~2024-08-29 12:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-28  1:03 bug#72848: [PATCH RESEND] xwidget: Fix xwidget-at misinterpreting non-xwidget text-properties George Huebner
2024-08-29 12:13 ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86bk1bfrw9.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=72848-done@debbugs.gnu.org \
    --cc=george@feyor.sh \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.