all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Sebastián Monía" <sebastian@sebasmonia.com>
Cc: jporterbugs@gmail.com, ozzloy@challenge-bot.com,
	65973@debbugs.gnu.org, ozzloy@gmail.com
Subject: bug#65973: [PATCH] ; send filename, not full path, on EWW form submit
Date: Tue, 05 Nov 2024 19:08:02 +0200	[thread overview]
Message-ID: <86bjyttxql.fsf@gnu.org> (raw)
In-Reply-To: <thqn4j4lhhq1.fsf@sebasmonia.com> (sebastian@sebasmonia.com)

> Cc: daniel watson <ozzloy@challenge-bot.com>, 65973@debbugs.gnu.org
> From: Sebastián Monía
>  <sebastian@sebasmonia.com>
> Date: Tue, 05 Nov 2024 09:34:46 -0500
> 
> 
> /added Jim for visibility/
> 
> This seems like something simple enough to merge.
> Thoughts?
> 
> ozzloy <ozzloy@gmail.com> writes:
> >  bump
> >
> >  On Wed, Sep 13, 2023 at 11:10 PM daniel watson <ozzloy@challenge-bot.com> wrote:
> >
> >  0. in one terminal, run this http server
> >     https://git.sr.ht/~ozzloy/emacs-bug-63941/tree/master/item/server.py
> >  1. in another terminal, run
> >     socat -v tcp-listen:8086,fork tcp:localhost:8085
> >  2. browse to the page with EWW,
> >     M-x eww <ENTER> localhost:8086 <ENTER>
> >  3. put the cursor on the word "Browse" <ENTER>
> >  4. select any file to which you have read access for uploading
> >  5. put cursor on "Submit" <ENTER>
> >  6. observe the full path of the file is sent to the server.  this is
> >     visible in both the python output and the socat output.
> >
> >  i'm including the diff inline to make it easier to review without
> >  downloading the attached file.

I'd like some rationale for this change.  The original report never
explains why sending the full absolute file name to the server is bad.

Please note that using file names without directories in Emacs means
that the file is presumed to live in the current-buffer's
default-directory.  I'm not sure I understand why this is correct in
this case, and neither am I sure that the server will interpret it
like that (because the server might run in a different directory).
But maybe I'm missing something important here.

Thanks.





  reply	other threads:[~2024-11-05 17:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-14  6:10 bug#65973: [PATCH] ; send filename, not full path, on EWW form submit daniel watson via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-15 11:47 ` Stefan Kangas
2023-09-19  7:15   ` daniel watson via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-02 15:02 ` ozzloy
2024-11-05 14:34   ` Sebastián Monía
2024-11-05 17:08     ` Eli Zaretskii [this message]
2024-11-05 19:36       ` Jim Porter
2024-11-06  3:30         ` Sebastián Monía
2024-11-06 15:34           ` daniel watson
2024-11-06 23:30         ` Stefan Kangas
2024-11-07  6:20           ` Eli Zaretskii
2024-11-07 18:58             ` Jim Porter
2024-11-08  1:33             ` Stefan Kangas
2024-11-07 18:52         ` Jim Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86bjyttxql.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=65973@debbugs.gnu.org \
    --cc=jporterbugs@gmail.com \
    --cc=ozzloy@challenge-bot.com \
    --cc=ozzloy@gmail.com \
    --cc=sebastian@sebasmonia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.