From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#75199: 30.0.93; Emacs crashes when completing with corfu Date: Mon, 30 Dec 2024 20:28:38 +0200 Message-ID: <86bjwtnhyh.fsf@gnu.org> References: <87cyh9qq64.fsf@fuzy.me> <86ttalnsj4.fsf@gnu.org> <87r05pmctv.fsf@fuzy.me> <86ldvxnqgv.fsf@gnu.org> <8ac665654425902f3deb81481ac0242c@fuzy.me> <87a5cdcape.fsf@daniel-mendler.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40430"; mail-complaints-to="usenet@ciao.gmane.io" Cc: i@fuzy.me, luangruo@yahoo.com, 75199@debbugs.gnu.org To: Daniel Mendler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 30 19:32:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tSKYn-000AO7-Sw for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Dec 2024 19:32:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tSKYe-0005Nw-Rb; Mon, 30 Dec 2024 13:32:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tSKYd-0005Nb-2c for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2024 13:32:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tSKYc-0004ng-Qc for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2024 13:32:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=5bVnzj32ovjM5IkoU8BrlA+BaZVnRbOtms+CqbjdD+A=; b=QtrleI/P6w72rPgoKT3wRiroMecvYUFVU508jWi8Mx2mtypEQKBtXkuJlLf99G9SrUnQbQ52kNGHcQDYMtrvU6DLr45b+JqkOyLKPb2OnuTBKFNSlMHwS3u9LQncLthQE6n0l0sJnxPBYIAcLTguyMdFvcos68bQmaD+jntUmQAkOpY6Oa3g3BG7uCV+a0KRC7zzaa6KDtYigfRSYiGK+Itw6w/RW1EqhLWeltd5r8JxOpSKEentbA5MQl8nUM8ABi7MJjxMQ23HsSwVCqPdNQ382MeoH47gAY24nJjA1ZOUCDsrml0r2+4rlKXfga9ceE8jClGRfbwpoLiYsgfJdQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tSKYc-0008Vd-Kb for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2024 13:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Dec 2024 18:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75199 X-GNU-PR-Package: emacs Original-Received: via spool by 75199-submit@debbugs.gnu.org id=B75199.173558346832627 (code B ref 75199); Mon, 30 Dec 2024 18:32:02 +0000 Original-Received: (at 75199) by debbugs.gnu.org; 30 Dec 2024 18:31:08 +0000 Original-Received: from localhost ([127.0.0.1]:59945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tSKXj-0008UA-QY for submit@debbugs.gnu.org; Mon, 30 Dec 2024 13:31:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tSKXf-0008TY-H6 for 75199@debbugs.gnu.org; Mon, 30 Dec 2024 13:31:07 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tSKVQ-0004QO-S9; Mon, 30 Dec 2024 13:28:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=5bVnzj32ovjM5IkoU8BrlA+BaZVnRbOtms+CqbjdD+A=; b=cWiKbY8paI57 T2FUwNucxzvs9/1DOPVMQrEW+79e5jvI4D3EJWCO1SSlbNzwo91STnhDorqHSp48AnA4lz1uW0r1J s9uwEtqR1gSZ34lA8hIi2HBQRXMhQwVOcBG0e6/VwnUNeypwPBkA9gOAMXxcn/7yrFcP4neARvIDw oA1b20YUGKUCD/KY+LLp3PXmTOnWITf0ikcnIArCjFDp40DDLerhfXyh+QuKQJOms+RF5RAXRj2uU Q0J9/JmKthn/saFLvge4ypnXhVVF7IYn8/TnJ15G7PWuGErwV8bYdGNBXh4ow1/7b1Cn0yDxgwGM1 tQWF2/yn6IAsdVPvBl8l2w==; In-Reply-To: <87a5cdcape.fsf@daniel-mendler.de> (message from Daniel Mendler on Mon, 30 Dec 2024 19:00:45 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298016 Archived-At: > From: Daniel Mendler > Cc: Eli Zaretskii , luangruo@yahoo.com, 75199@debbugs.gnu.org > Date: Mon, 30 Dec 2024 19:00:45 +0100 > > Zhengyi Fu writes: > > > On 2024-12-30 23:24, Eli Zaretskii wrote: > > > >> Earlier you wrote: > >> > >>> The error is probably caused by the width value of 0 passed to > >>> XCreatePixmapFromBitmapData(). > >>> It seems gui_intersect_rectangles() returns true even if the resulted > >>> rectangle is empty. Is that correct behavior? > >> Can you tell how this happens? Is corfu doing something special with > >> the fringes? > > > > I noticed the following calls in corfu--popup-show before the error: > > > > * define-fringe-bitmap(corfu--bar [-241] 1 8 (top periodic)) > > * define-fringe-bitmap(corfu--nil []) > > I've adjusted the second call to the following, also for compatibility > with older Emacs versions. > > (define-fringe-bitmap 'corfu--nil [0] 1 1) Doesn't (define-fringe-bitmap 'corfu--nil [0]) work as well? If it doesn't, I guess the doc string is inaccurate? > For the future, maybe `define-fringe-bitmap' should either check its > argument carefully and disallow empty bitmaps, or empty bitmaps should > be explicitly allowed? Adding such argument-checking is fine by me, patches welcome. Thanks.