From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Windows mingw64 and cygwin builds broken Date: Fri, 13 Nov 2015 10:18:22 +0000 Message-ID: <86a8qiyzgx.fsf@gmail.com> References: <867flnrnhg.fsf@gmail.com> <83y4e3gdbb.fsf@gnu.org> <86y4e2rhom.fsf@gmail.com> <836116gt5t.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1447410055 23123 80.91.229.3 (13 Nov 2015 10:20:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 13 Nov 2015 10:20:55 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 13 11:20:47 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZxBSz-0002ca-Py for ged-emacs-devel@m.gmane.org; Fri, 13 Nov 2015 11:20:25 +0100 Original-Received: from localhost ([::1]:52068 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxBSz-0001x2-OS for ged-emacs-devel@m.gmane.org; Fri, 13 Nov 2015 05:20:25 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60660) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxBSm-0001wg-Da for emacs-devel@gnu.org; Fri, 13 Nov 2015 05:20:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZxBSh-00048A-Ht for emacs-devel@gnu.org; Fri, 13 Nov 2015 05:20:12 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:59827) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxBSh-00047l-Aa for emacs-devel@gnu.org; Fri, 13 Nov 2015 05:20:07 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1ZxBRu-0001W0-Ge for emacs-devel@gnu.org; Fri, 13 Nov 2015 11:19:18 +0100 Original-Received: from 82-69-64-228.dsl.in-addr.zen.co.uk ([82.69.64.228]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 13 Nov 2015 11:19:18 +0100 Original-Received: from andrewjmoreton by 82-69-64-228.dsl.in-addr.zen.co.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 13 Nov 2015 11:19:18 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 32 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 82-69-64-228.dsl.in-addr.zen.co.uk User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5.50 (windows-nt) Cancel-Lock: sha1:S7z+lgs+tu0+XBrRNvtIfPHqSQQ= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:194345 Archived-At: On Fri 13 Nov 2015, Eli Zaretskii wrote: >> From: Andy Moreton >> Date: Thu, 12 Nov 2015 22:12:09 +0000 >> >> On Thu 12 Nov 2015, Eli Zaretskii wrote: >> >> >> From: Andy Moreton >> >> Date: Thu, 12 Nov 2015 20:06:51 +0000 >> >> >> >> Changes in commit 9d43941569fc broke the Windows builds. >> > >> > Thanks, I tried to fix those problems in c1bc6e5. >> >> The cygwin w32 build needs an additional patch: > > Thanks, fixed. Both the cygwin-w32 and mingw64 builds now need to be configured with --without-dbus to avoid a crash when dumping. As users may want to use D-Bus with cygwin-w32 emacs (and possibly with mingw64 emacs), a configure option is needed for the w32-notifications. The change in requirements to build emacs also needs to be documented in NEWS. Can you also please explain what was wrong with the patch I sent, which was simpler than your solution. Does it make sense to build emacs with support for both D-Bus and w32-notifications, and for the user to choose which is enabled at runtime ? AndyM