* Re: master ef44346 2/2: Make it easier to abort a series of tests with C-g
@ 2017-03-28 9:29 Lars Brinkhoff
2017-03-28 13:48 ` Noam Postavsky
0 siblings, 1 reply; 3+ messages in thread
From: Lars Brinkhoff @ 2017-03-28 9:29 UTC (permalink / raw)
To: emacs-devel
Noam Postavsky wrote:
> Make it easier to abort a series of tests with C-g
>
> * emacs-lisp/ert.el (ert-run-tests): Add "interactively" arg. If
> interactively is true and a test was aborted then ask if the remaining
> tests should be aborted too.
> (ert-run-tests-batch, ert-run-tests-interactively): Pass in
> interactively arg.
This commit adds a testsuite failure when I run:
git clean -xfd && ./autogen.sh && make bootstrap && make check
If I revert this commit, the failure goes away. It seems there's a call
to ert-run-tests that hasn't been updated with a third argument.
From test/lisp/emacs-lisp/ert-x-tests.el:
Test ert-test-test-buffers backtrace:
(let ((test-1 (progn "Constructor for objects of type `ert-test'." (
(let (buffer-1 buffer-2) (let ((test-1 (progn "Constructor for objec
(lambda nil (let (buffer-1 buffer-2) (let ((test-1 (progn "Construct
ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc
ert-run-test([cl-struct-ert-test ert-test-test-buffers nil (lambda n
ert-run-or-rerun-test([cl-struct-ert--stats (not (tag :expensive-tes
ert-run-tests((not (tag :expensive-test)) #[385 "\306\307\"\203G^@\2
ert-run-tests-batch((not (tag :expensive-test)))
ert-run-tests-batch-and-exit((not (tag :expensive-test)))
eval((ert-run-tests-batch-and-exit (quote (not (tag :expensive-test)
command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/ert-x-tes
command-line()
normal-top-level()
Test ert-test-test-buffers condition:
(wrong-number-of-arguments
(3 . 3)
2)
FAILED 9/9 ert-test-test-buffers
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master ef44346 2/2: Make it easier to abort a series of tests with C-g
2017-03-28 9:29 master ef44346 2/2: Make it easier to abort a series of tests with C-g Lars Brinkhoff
@ 2017-03-28 13:48 ` Noam Postavsky
2017-03-28 17:57 ` Lars Brinkhoff
0 siblings, 1 reply; 3+ messages in thread
From: Noam Postavsky @ 2017-03-28 13:48 UTC (permalink / raw)
To: Lars Brinkhoff; +Cc: Emacs developers
On Tue, Mar 28, 2017 at 5:29 AM, Lars Brinkhoff <lars@nocrew.org> wrote:
> Noam Postavsky wrote:
>> Make it easier to abort a series of tests with C-g
>>
>> * emacs-lisp/ert.el (ert-run-tests): Add "interactively" arg. If
>> interactively is true and a test was aborted then ask if the remaining
>> tests should be aborted too.
>> (ert-run-tests-batch, ert-run-tests-interactively): Pass in
>> interactively arg.
>
> This commit adds a testsuite failure when I run:
> git clean -xfd && ./autogen.sh && make bootstrap && make check
>
> If I revert this commit, the failure goes away. It seems there's a call
> to ert-run-tests that hasn't been updated with a third argument.
Oops, right. I've made that argument &optional in [1: 7d27f5d8f4].
1: 2017-03-28 09:44:24 -0400 7d27f5d8f48b8f184eb93f64461e01c1481c8fb4
* lisp/emacs-lisp/ert.el (ert-run-tests): Make INTERACTIVE arg optional.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master ef44346 2/2: Make it easier to abort a series of tests with C-g
2017-03-28 13:48 ` Noam Postavsky
@ 2017-03-28 17:57 ` Lars Brinkhoff
0 siblings, 0 replies; 3+ messages in thread
From: Lars Brinkhoff @ 2017-03-28 17:57 UTC (permalink / raw)
To: emacs-devel
Noam Postavsky wrote
>> This commit adds a testsuite failure when I run:
>> git clean -xfd && ./autogen.sh && make bootstrap && make check
>>
>> If I revert this commit, the failure goes away. It seems there's a call
>> to ert-run-tests that hasn't been updated with a third argument.
>
> Oops, right. I've made that argument &optional in [1: 7d27f5d8f4].
>
> 1: 2017-03-28 09:44:24 -0400 7d27f5d8f48b8f184eb93f64461e01c1481c8fb4
> * lisp/emacs-lisp/ert.el (ert-run-tests): Make INTERACTIVE arg optional.
Thanks, that fixes the failure.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-28 17:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-28 9:29 master ef44346 2/2: Make it easier to abort a series of tests with C-g Lars Brinkhoff
2017-03-28 13:48 ` Noam Postavsky
2017-03-28 17:57 ` Lars Brinkhoff
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.