From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Lars Brinkhoff Newsgroups: gmane.emacs.devel Subject: Re: master ef44346 2/2: Make it easier to abort a series of tests with C-g Date: Tue, 28 Mar 2017 19:57:19 +0200 Organization: nocrew Message-ID: <86a885i8sg.fsf@molnjunk.nocrew.org> References: <86poh1iwbh.fsf@molnjunk.nocrew.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1490723862 17150 195.159.176.226 (28 Mar 2017 17:57:42 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 28 Mar 2017 17:57:42 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 28 19:57:38 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csvNB-0003yN-Nn for ged-emacs-devel@m.gmane.org; Tue, 28 Mar 2017 19:57:37 +0200 Original-Received: from localhost ([::1]:54591 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csvNH-0004dt-TQ for ged-emacs-devel@m.gmane.org; Tue, 28 Mar 2017 13:57:43 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csvNC-0004dl-CY for emacs-devel@gnu.org; Tue, 28 Mar 2017 13:57:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1csvN9-0000ia-7F for emacs-devel@gnu.org; Tue, 28 Mar 2017 13:57:38 -0400 Original-Received: from [195.159.176.226] (port=43761 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1csvN9-0000i6-1V for emacs-devel@gnu.org; Tue, 28 Mar 2017 13:57:35 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1csvMy-0002fu-4H for emacs-devel@gnu.org; Tue, 28 Mar 2017 19:57:24 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 13 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:NQomvDuvSbBzIM8I+fQ5XvQDygk= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213457 Archived-At: Noam Postavsky wrote >> This commit adds a testsuite failure when I run: >> git clean -xfd && ./autogen.sh && make bootstrap && make check >> >> If I revert this commit, the failure goes away. It seems there's a call >> to ert-run-tests that hasn't been updated with a third argument. > > Oops, right. I've made that argument &optional in [1: 7d27f5d8f4]. > > 1: 2017-03-28 09:44:24 -0400 7d27f5d8f48b8f184eb93f64461e01c1481c8fb4 > * lisp/emacs-lisp/ert.el (ert-run-tests): Make INTERACTIVE arg optional. Thanks, that fixes the failure.