From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: syntax based indentation for SQL files (ELPA package proposal) Date: Mon, 01 Oct 2018 23:31:15 +0100 Message-ID: <86a7nxb8p8.fsf@gmail.com> References: <808t48ny4y.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1538433093 31057 195.159.176.226 (1 Oct 2018 22:31:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 1 Oct 2018 22:31:33 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 02 00:31:29 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g76iv-0007y5-5C for ged-emacs-devel@m.gmane.org; Tue, 02 Oct 2018 00:31:29 +0200 Original-Received: from localhost ([::1]:40984 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g76l1-0008Nh-6N for ged-emacs-devel@m.gmane.org; Mon, 01 Oct 2018 18:33:39 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38392) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g76iu-0006NH-7U for emacs-devel@gnu.org; Mon, 01 Oct 2018 18:31:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g76ir-0008CX-3q for emacs-devel@gnu.org; Mon, 01 Oct 2018 18:31:28 -0400 Original-Received: from [195.159.176.226] (port=50806 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g76iq-0008Bh-Sk for emacs-devel@gnu.org; Mon, 01 Oct 2018 18:31:25 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1g76gg-0005To-Vk for emacs-devel@gnu.org; Tue, 02 Oct 2018 00:29:10 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 27 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:TAE10PDFcVq2IAKi1/k6GQOk8tM= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230186 Archived-At: On Mon 01 Oct 2018, Michael Mauger wrote: > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ > On Sunday, September 16, 2018 5:30 PM, Stefan Monnier wrote: > >> > (defun sql-is-indent-available () >> >> > "Check if sql-indent module is available." >> > (when (locate-library "sql-indent") >> > (require 'sql-indent) >> > (fboundp 'sqlind-minor-mode))) >> > >> >> I'd recommend you just use (fboundp 'sqlind-minor-mode) since the ELPA >> package (or any proper manual install) sets up an autoload for it. >> >> Stefan > > I have pushed a change to sql.el to enable sqind-minor-mode if it is available. This patch looks like it has been applied in the wrong place. Emacs builtin code should not depend on an external package. Why did you add this change into emacs, rather than the package that defines sqind-minor-mode ? AndyM