From: Andy Moreton <andrewjmoreton@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: syntax based indentation for SQL files (ELPA package proposal)
Date: Mon, 01 Oct 2018 23:31:15 +0100 [thread overview]
Message-ID: <86a7nxb8p8.fsf@gmail.com> (raw)
In-Reply-To: mVZ2LoSXINHamLlKAon39WtehwpgUhzKOB99tN3LuYSmAFPK52mnrQlwvFP0F8tAsnGLDTkhJfyvvH6WBpcs9g==@protonmail.com
On Mon 01 Oct 2018, Michael Mauger wrote:
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> On Sunday, September 16, 2018 5:30 PM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>
>> > (defun sql-is-indent-available ()
>>
>> > "Check if sql-indent module is available."
>> > (when (locate-library "sql-indent")
>> > (require 'sql-indent)
>> > (fboundp 'sqlind-minor-mode)))
>> >
>>
>> I'd recommend you just use (fboundp 'sqlind-minor-mode) since the ELPA
>> package (or any proper manual install) sets up an autoload for it.
>>
>> Stefan
>
> I have pushed a change to sql.el to enable sqind-minor-mode if it is available.
This patch looks like it has been applied in the wrong place. Emacs
builtin code should not depend on an external package. Why did you add
this change into emacs, rather than the package that defines
sqind-minor-mode ?
AndyM
next prev parent reply other threads:[~2018-10-01 22:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-06 2:42 syntax based indentation for SQL files (ELPA package proposal) Alex Harsanyi
2017-08-06 4:05 ` Stefan Monnier
2017-08-06 6:35 ` Steinar Bang
2017-08-06 13:30 ` Alex Harsanyi
2017-08-06 17:54 ` Stefan Monnier
[not found] ` <j3XyL-aaKw13ov6PDSlK6YTLNYM6WwKGtS-OW5wgKzI9C4QQ1lDjHvosCxVSOEbqEaQOThHg4DKnPLVJO9ogqg==@protonmail.com>
2017-08-14 9:51 ` Stefan Monnier
2017-08-14 20:47 ` John Wiegley
2018-09-11 10:09 ` simenheg
2018-09-11 12:16 ` Stefan Monnier
2018-09-16 1:11 ` Michael Mauger
2018-09-16 21:30 ` Stefan Monnier
2018-10-01 12:56 ` Michael Mauger
2018-10-01 18:24 ` Stefan Monnier
2018-10-01 22:31 ` Andy Moreton [this message]
2018-10-02 12:57 ` Stefan Monnier
2018-10-02 13:48 ` Andy Moreton
2018-10-02 14:24 ` Van L
2018-10-02 16:07 ` Stefan Monnier
2018-10-02 13:49 ` Thomas Fitzsimmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86a7nxb8p8.fsf@gmail.com \
--to=andrewjmoreton@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.